feat: clean up distrobox exports/entries even if container is already deleted by iTrooz · Pull Request #2062 · 89luca89/distrobox

iTrooz · 2026-04-20T09:08:17Z

See #2060

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

* build(deps): add urfave/cli Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * chore: add gitignore Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * ci: add golangci configuration Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * build(Makefile): add Makefile Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat: add main package and distrobox cmd Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> --------- Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

* feat: add containermanager package and docker provider Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat: add list command Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat: add root command Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat: add list command Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat: wire-up root command in main Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * refactor(docker): use format json Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> --------- Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

* chore: disable mdlint (89luca89#6) * resolve lint issues Some issues where detected by the CI once run: * use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) * File is not properly formatted (goimports) * Magic number: 12, in <condition> detected (mnd) * error-format: fmt.Errorf can be replaced with errors.New (perfsprint) --------- Co-authored-by: Alessio Biancalana <alessio@dottorblaster.it>

Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

* feat(cli): validate sudo (sudo -v) in beforeCommand if --root is set Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat(docker): add root and sudoCommand and execute commands with sudo if root is set Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * feat(cli): add --root description and -r alias Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> --------- Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

* add GenerateEntryCommand package The package mimics the actual distrobox-generate-entry shell command that installs a desktop entry file so that the host's desktop environment can render the appropriate application icon. This first implementantion scaffolds the command package and implements the simplest scenario for a single container. * delete entry If the `delete` flag is provided, the command remove the desktop entry if present. Deleting a non-existing item does not raise an error. * generate entries for all containers With `opts.All` we implement an abstraction over the `GenerateEntryCommand` that iterates across all the containers to generate or delete the relative desktop entries. `ListCommand` is used to fetch the list of containers. * mount the generate-entry cli command Mount the command so that is reachable from the CLI. Define parameters with type and basic validation. Depending on the flag `--all`, the appropriate set of options is provided to the `GenerateEntryCommand.Execute()` method. If `--all` is set, `container-name` and `icon` arguments will be ignored.

* embed shell scripts to execute inside the distrobox The command init, export and host-exec must be accessible from inside the distrobox container. When needed, the embedded scripts will be written to a host directory and then mounted as volume on the created container. The host directory is determined by configuration and environment variables. The script will be not converted to GO to keep then architecture-agnostic. * add Create to the Docker container manager The function will compose argument string to append to the `docker` command. If `DryRun=true`, the command is just printed on screen and not executed. * add Create command package * mount cli command

* feat: add config Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * build(deps): add testify Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> * test(config): add config loading test Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com> --------- Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

* feat(enter): rewrite in go * chore: make InspectContainer public * chore: use userenv package for user's environment * chore: export InspectResult type for convenience * fix: rename containerInspect to inpectOutput * fix: use userenv inside generateEnterCommand * fix(enter): more userenv * chore: add some unit tests for buildContainerPath and buildCommandArgs

* read desktop entry directory and distrobox path from the global config * implement entry generation requested from user

* remove unused ID field * add a test for include order

* scaffold assemble command * mount assemble command * implement create item

Manifest can either be file or remote URLs. In the latter case, the content is fetched into a temporary file; then the parsing follows as usual. Note that the HTTP fetch has no constraint on protocol to use nor an allowed list of URLs, just like in the original `assemble` command. https://github.com/89luca89/distrobox/blob/main/distrobox-assemble#L240 ``` if command -v curl > /dev/null 2>&1; then download="curl --connect-timeout 3 --retry 1 -sLo" elif command -v wget > /dev/null 2>&1; then download="wget --timeout=3 --tries=1 -qO" ``` The only difference with the original implementation is that the file input is checked to be a valid URL.

* feat: rewrite rm in go * fix: declare yes and no as string slices

* move the Propter under screen package * add color formatters * add progress This module allows for printing a sequence of lines with check marks. Useful to show progress on a long running action (example: container init). * implement progess on create * implement progress on assemble * implement progress on enter * implement color * move internal/screen to pkg/ui * add printer * implement printer * fix progress finalize method * fix progress implementation for enter command

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

Replace helper functions (lastString, lastBool, allStrings, splitString) with a single loop that fetches ValueWithShadows() once per key. This avoids repeated calls to the ini library for each field. Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

…ect-binary fix(providers): execute correct binary for podman-launcher provider

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

… deleted

iTrooz · 2026-04-20T09:14:24Z

I also added a failsafe on cleanup() because I accidentally triggered it with an empty container name during tests, and ended up deleting a lot of other files on my computer. Tell me if you'd prefer me to remove it :)

Copilot

Pull request overview

Adds behavior to distrobox rm to also clean up exported binaries/desktop entries for explicitly requested containers even when the container no longer exists, aligning with the “Remove exported apps” workflow discussed in #2059.

Changes:

Track explicitly requested container names that were not found/removed and run cleanup for them.
Add a small slice helper to remove handled names from the explicit list.
Add a guard in cleanup() for empty container names.

Comments suppressed due to low confidence (1)

pkg/commands/rm.go:88

This fmt.Printf call lacks a trailing newline, which can make output from multiple deletions run together and be harder to read. Consider adding "\n" (and/or routing through the logger once available).

			//nolint:forbidigo // waiting for the logger implementation
			fmt.Printf("error deleting %s: %s", currentDistrobox.Name, err)
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

iTrooz · 2026-05-05T12:08:15Z

Hello ! Any news ? Changes I need to make ?

balanza · 2026-05-05T16:02:29Z

Hi,

Right now, we are focusing on making Distrobox v2 stable, which means having feature parity with Distrobox v1. That implies that, for the moment, we are not considering new features or bug fixes besides those that are trivial to merge and do not require much brain power from us.

On this PR, we are not convinced by the implementation, but at the same time, we cannot give you the level of feedback you deserve.

Let's postpone this contribution until Distrobox v2 is stable.

Closing for now.

iTrooz · 2026-05-05T16:09:28Z

Would you mind reopening & drafting this PR instead, so it's still on my feed and I remember to come back to it later ? Thanks

fabriziosestito and others added 30 commits March 28, 2026 15:13

chore: go mod init rewrite

6534766

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

chore: disable mdlint (89luca89#6)

223a261

fix formatting (89luca89#8)

d7cdc6f

chore: add rfc 0001 for golang rewrite (89luca89#5)

70b209a

fix: generate-entry tests against new docker interface (89luca89#13)

b103986

refactor run (89luca89#16)

29bd74e

parse manifest files (89luca89#18)

32d547a

feat(create): Generate desktop entry on create (89luca89#17)

8ac07d5

* read desktop entry directory and distrobox path from the global config * implement entry generation requested from user

fix(assemble): refine manifest item type (89luca89#19)

625e10f

* remove unused ID field * add a test for include order

fix(create): fix argument passing (89luca89#21)

b7fd44d

increase since timestamp at every iteration (89luca89#22)

d00ebf0

feat(assemble): implement create with assemble (89luca89#20)

8178622

* scaffold assemble command * mount assemble command * implement create item

feat(rm): rewrite in go (89luca89#23)

1585932

* feat: rewrite rm in go * fix: declare yes and no as string slices

fix(rm): remove only distrobox (89luca89#25)

55e1bb2

chore(rm): refactor options passing (#26)

6caae60

feat(assemble): implement rm and replace (89luca89#27)

bbb0789

refactor: simplify manifest parsing with iniv1 library

10aa11e

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

chore(manifest): rename tests to something more idiomatic

b909ce5

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

fabriziosestito and others added 5 commits April 16, 2026 12:07

fix(cli): add podman-laucher to invalid container manager message

f309735

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

fix(providers): Name now returns podman or podman-launcher

28dbb6e

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

Merge pull request 89luca89#2056 from fabriziosestito/feat/podman-sel…

b89fd49

…ect-binary fix(providers): execute correct binary for podman-launcher provider

refactor: tests with testify (89luca89#2057)

9f6e852

Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>

feat: clean up distrobox exports/entries even if container is already…

9a924b3

… deleted

panic if cleanup() is run with an empty container name

a48ad88

iTrooz force-pushed the next_delete_distrobox_desktop_first branch from db0ba66 to a48ad88 Compare April 20, 2026 09:14

balanza requested a review from Copilot April 22, 2026 12:25

Copilot started reviewing on behalf of balanza April 22, 2026 12:26 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread pkg/commands/rm.go Outdated

Comment thread pkg/commands/rm.go Outdated

Comment thread pkg/commands/rm.go Outdated

Comment thread pkg/commands/rm.go Outdated

Comment thread pkg/commands/rm.go Outdated

balanza requested changes Apr 22, 2026

View reviewed changes

Comment thread pkg/commands/rm.go Outdated

Comment thread pkg/commands/rm.go Outdated

balanza self-assigned this Apr 22, 2026

iTrooz added 4 commits April 22, 2026 16:01

remove comment

e7ffc98

add proper cotnainer name validation

bcd8774

explicitely -> explicitly

8caa58a

fix typo

3b73f5a

balanza closed this May 5, 2026

89luca89 reopened this May 5, 2026

89luca89 marked this pull request as draft May 5, 2026 17:19

dottorblaster force-pushed the next branch from e251b5e to 5f52050 Compare June 11, 2026 16:27

balanza force-pushed the next branch from c767be7 to ba60f37 Compare June 14, 2026 10:20

dottorblaster force-pushed the next branch 5 times, most recently from 2db8252 to ab1b3ac Compare June 14, 2026 11:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: clean up distrobox exports/entries even if container is already deleted#2062

feat: clean up distrobox exports/entries even if container is already deleted#2062
iTrooz wants to merge 114 commits into
89luca89:nextfrom
iTrooz:next_delete_distrobox_desktop_first

iTrooz commented Apr 20, 2026 •

edited

Loading

Uh oh!

iTrooz commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iTrooz commented May 5, 2026

Uh oh!

balanza commented May 5, 2026

Uh oh!

iTrooz commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

iTrooz commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iTrooz commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iTrooz commented May 5, 2026

Uh oh!

balanza commented May 5, 2026

Uh oh!

iTrooz commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

iTrooz commented Apr 20, 2026 •

edited

Loading