fix(list): detect containers with overridden manager label#2116
Merged
dottorblaster merged 1 commit intoMay 26, 2026
Conversation
When `--additional-flags --label=manager=...` overrides the manager label at creation time, `distrobox list` would hide the container and `distrobox rm` would silently no-op (it filters through the same list). Match the distrobox.* label set alongside `manager` so containers remain detectable when the manager label is overridden, restoring v1's loose `*distrobox*` substring behavior.
fabriziosestito
approved these changes
May 26, 2026
dottorblaster
deleted the
fix-container-detection-overridden-manager-label
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--additional-flags --label=manager=...overrides the manager label at creation time,distrobox listwould hide the container anddistrobox rmwould silently no-op (it filters through the same list). Match the distrobox.* label set alongsidemanagerso containers remain detectable when the manager label is overridden, restoring v1's loose*distrobox*substring behavior.Fixes #2112