Skip to content

Change default service name to prevent conflic with N8N_PORT #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Change default service name to prevent conflic with N8N_PORT #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/n8n/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
pathType: Prefix
backend:
service:
name: {{ $fullName }}
name: {{ $fullName }}-svc
port:
number: {{ $.Values.main.service.port | default 80 }}
Comment on lines 36 to 39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Only the root path was updated – /webhook-test/ still points to a non-existent service

The backend for the root path now targets {{ $fullName }}-svc, but the /webhook-test/ rule (line 53) still targets {{ $fullName }}. After this rename, manual-execution webhooks will return 503. Align all paths that should hit the main process:

-                name: {{ $fullName }}
+                name: {{ $fullName }}-svc
🤖 Prompt for AI Agents 
In charts/n8n/templates/ingress.yaml between lines 36 and 39, the service name
for the root path was updated to {{ $fullName }}-svc, but the /webhook-test/
path at line 53 still targets {{ $fullName }}. To fix the 503 errors on
manual-execution webhooks, update the service name in the /webhook-test/ path
rule to {{ $fullName }}-svc so it matches the renamed service and routes
correctly.

{{- if $.Values.webhook.enabled }}
Expand Down
2 changes: 1 addition & 1 deletion charts/n8n/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: Service
metadata:
name: {{ include "n8n.fullname" . }}
name: {{ include "n8n.fullname" . }}-svc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Renaming breaks remaining unsuffixed references – update them or expect 503s

Changing the Service name to {{ include "n8n.fullname" . }}-svc is sensible, but all chart objects that still reference the old name will now fail.
A quick grep already shows an unsuffixed use in charts/n8n/templates/ingress.yaml (line 53) and possibly elsewhere (HPA, ServiceMonitor, NetworkPolicy, tests, docs). Update every reference before shipping.

🏁 Script executed:

#!/bin/bash
# Find all unsuffixed service references in the chart
fullname='{{[[:space:]]*include[[:space:]]+"n8n.fullname"[[:space:]]*\.[[:space:]]*}}'
rg -n "$fullname" charts/n8n/templates | grep -v '\-svc' || true

Length of output: 371

🏁 Script executed:

#!/usr/bin/env bash
# Find all literal Helm include calls of n8n.fullname missing the "-svc" suffix
rg -n '{{ include "n8n.fullname" . }}' charts/n8n/templates | grep -v '\-svc' || true

Length of output: 192

🏁 Script executed:

#!/usr/bin/env bash
# Search for literal Helm fullname includes missing the "-svc" suffix using fixed string matching
rg -F '{{ include "n8n.fullname" . }}' -n charts/n8n/templates/*.yaml | grep -v -- '-svc' || true

Length of output: 2925

🏁 Script executed:

#!/usr/bin/env bash
# Inspect ingress.yaml around expected service reference
sed -n '40,80p' charts/n8n/templates/ingress.yaml

Length of output: 1307

Update the ingress service reference to include the “-svc” suffix

The Service name was changed to {{ include "n8n.fullname" . }}-svc, so any backend that still points to the unsuffixed name will 404/503. A single occurrence was found in your ingress:

• charts/n8n/templates/ingress.yaml (around line 53)

 - backend:
     service:
-        name: {{ $fullName }}
+        name: {{ $fullName }}-svc

No other literal service references to {{ include "n8n.fullname" . }} appear in contexts that map to the Service object.
Please apply this change before shipping to avoid broken routes.

🤖 Prompt for AI Agents 
In charts/n8n/templates/ingress.yaml around line 53, update the backend service
name to include the "-svc" suffix to match the Service name defined as {{
include "n8n.fullname" . }}-svc. Replace any occurrence of {{ include
"n8n.fullname" . }} with {{ include "n8n.fullname" . }}-svc in the ingress
backend service reference to prevent 404/503 errors.

labels:
{{- include "n8n.labels" . | nindent 4 }}
{{- with .Values.main.service.annotations }}
Expand Down