Fix: prevent workers restart when valkey configuration is updated

[dberkerdem]

A quick fix for #214. The checksum is no longer dependent on Valkey configuration changes, i.e. services are decoupled.

Summary by CodeRabbit

• Bug Fixes

  • Updated the worker deployment to prevent unnecessary restarts when unrelated configuration changes are made.
  • Improved the changelog to reflect the fix for worker restarts related to Valkey configuration updates.

• Chores

  • Incremented the Helm chart version to 1.0.12.

[coderabbitai]

Walkthrough

The changes update the Helm chart version and changelog for the n8n application and refine how the worker deployment's configuration checksum is calculated. The checksum now considers only specific configuration sections, rather than the entire values object, to determine when worker pods should restart.

Changes

Cohort / File(s)	Change Summary
Chart Metadata Update charts/n8n/Chart.yaml	Incremented chart version from 1.0.11 to 1.0.12 and updated the changelog annotation to reflect a new fix.
Worker Deployment Checksum Logic charts/n8n/templates/deployment.worker.yaml	Modified the checksum calculation for the worker deployment to only include .Values.main, .Values.worker, and .Values.webhook instead of the entire .Values object.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6b7ae4 and b9ee10c.

📒 Files selected for processing (1)

• charts/n8n/Chart.yaml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• charts/n8n/Chart.yaml

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

charts/n8n/Chart.yaml (1)

37-38: Improve changelog grammar for clarity.

Current wording is slightly awkward (“prevent workers restart”). Consider:

-      description: "prevent workers restart when Valkey configuration is updated: fixes https://github.com/8gears/n8n-helm-chart/issues/214"
+      description: "Prevent worker restarts when the Valkey configuration is updated (fixes #214)."

charts/n8n/templates/deployment.worker.yaml (1)

32-34: Potential key-collision in merge, consider safer construction.

merge .Values.main .Values.worker .Values.webhook flattens the three maps and overwrites duplicate keys with the right-most value, which can hide changes and prevent intended restarts (e.g., config.n8n present in both main and worker).
Safer pattern:

-        checksum/config: {{ merge .Values.main .Values.worker .Values.webhook | toJson | sha256sum }}
+        # keep sub-objects separate to avoid key collisions
+        checksum/config: {{ toJson (dict "main" .Values.main "worker" .Values.worker "webhook" .Values.webhook) | sha256sum }}

This still excludes valkey while guaranteeing that identical keys in different sections are both tracked.

Ensure no templating regressions by running a Helm diff/render against representative values files.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5a4b1e and a6b7ae4.

📒 Files selected for processing (2)

• charts/n8n/Chart.yaml (2 hunks)
• charts/n8n/templates/deployment.worker.yaml (1 hunks)

🔇 Additional comments (1)

charts/n8n/Chart.yaml (1)

3-3: Chart version bump looks correct.

Incrementing version from 1.0.11 to 1.0.12 follows SemVer for a patch-level fix.
No action required.