Skip to content

feat: implement terminationGracePeriodSeconds for all pods #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: implement terminationGracePeriodSeconds for all pods #216

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57c1a57
feat: implement terminationGracePeriodSeconds for all pods
matiaszilli Aug 1, 2025
c79f0b4
fix: implement hasKey which respects zero value
matiaszilli Aug 1, 2025
9103fca
chore: update readme
matiaszilli Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/n8n/templates/deployment.webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if hasKey .Values.webhook "terminationGracePeriodSeconds" }}
terminationGracePeriodSeconds: {{ .Values.webhook.terminationGracePeriodSeconds }}
{{- end }}
volumes:
- name: "data"
{{ include "n8n.pvc" . }}
Expand Down
3 changes: 3 additions & 0 deletions charts/n8n/templates/deployment.worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if hasKey .Values.worker "terminationGracePeriodSeconds" }}
terminationGracePeriodSeconds: {{ .Values.worker.terminationGracePeriodSeconds }}
{{- end }}
volumes:
- name: "data"
{{ include "n8n.pvc" . }}
Expand Down
3 changes: 3 additions & 0 deletions charts/n8n/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if hasKey .Values.main "terminationGracePeriodSeconds" }}
terminationGracePeriodSeconds: {{ .Values.main.terminationGracePeriodSeconds }}
{{- end }}
volumes:
- name: "data"
{{ include "n8n.pvc" . }}
Expand Down
9 changes: 9 additions & 0 deletions charts/n8n/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,9 @@ main:
tolerations: []
affinity: {}

# Pod termination grace period in seconds
terminationGracePeriodSeconds: 30

# # # # # # # # # # # # # # # #
#
# Worker related settings
Expand Down Expand Up @@ -451,6 +454,9 @@ worker:
tolerations: []
affinity: {}

# Pod termination grace period in seconds
terminationGracePeriodSeconds: 30

# Webhook related settings
# With .Values.scaling.webhook.enabled=true you disable Webhooks from the main process, but you enable the processing on a different Webhook instance.
# See https://github.com/8gears/n8n-helm-chart/issues/39#issuecomment-1579991754 for the full explanation.
Expand Down Expand Up @@ -636,6 +642,9 @@ webhook:
tolerations: []
affinity: {}

# Pod termination grace period in seconds
terminationGracePeriodSeconds: 30

#
# User defined supplementary K8s manifests
#
Expand Down