-
Notifications
You must be signed in to change notification settings - Fork 203
Change valkey chart from bitnami to coudpirates, update n8n app #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bitnami stopped support for their free public charts, that´s why we should move to a good alternative, which is cloudpirates.
WalkthroughBumps Helm chart metadata version and appVersion, switches the valkey dependency repository and version, and updates the changelog annotation in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
is this a drop in replacement for the bitnami chart? |
No, it is not equal to the latest states of bitnamis charts or images. Though they worked good so far with just few or no changes at all. I like their approach and their charts look good. Here is what they say about their alternatives for bitnami, unfortunately just available in german: https://www.cloudpirates.io/knowledge/blog/unsere-open-source-helm-charts-als-bitnami-alternative |
And to be clear. For the chart here it works as a drop in replacement. Just this PR without any further modifications worked for us to deploy a working valkey. |
I would rather prefer to switch to the official Valkey Helm chart. |
What this PR does / why we need it
This PR replaces the bitnami valkey chart with the one maintained by cloudpirates. This is required because bitnami stopped support for their free public charts. Also, as I was on it already, I updated n8n app version to the latest available.
Which issue this PR fixes
valkey can not be installed anymore because the image from the public bitnami chart is not available anymore.
Special notes for your reviewer
We already deployed n8n with he new valkey chart and it worked. You may want to test as well.
Checklist
Version and Documentation
Chart.yaml
following semantic versioningChart.yaml
if applicableartifacthub.io/changes
section updated inChart.yaml
(see ArtifactHub annotation reference)Testing and Validation
Summary by CodeRabbit