Skip to content

Conversation

weeix
Copy link
Contributor

@weeix weeix commented Oct 8, 2025

What this PR does / why we need it

This PR corrects a critical indentation error within the example configuration for webhook.extraEnv in both README.md and charts/n8n/values.yaml.

The previous indentation for the commented-out value field of the example WEBHOOK_URL would result in an invalid YAML structure if a user simply uncommented the lines, leading to potential misconfiguration or chart failures.

Before:

   #   WEBHOOK_URL:
-  #   value: "http://webhook.domain.tld"

After:

   #   WEBHOOK_URL:
+  #     value: "http://webhook.domain.tld"

The corrected indentation aligns the value key properly under the WEBHOOK_URL map.

Which issue this PR fixes

Special notes for your reviewer

This is a minor but important fix to ensure the YAML syntax is correct for users who rely on the examples in values.yaml and README.md. No functional code changes were made.

Checklist

Please place an 'x' in all applicable fields and remove unrelated items.

Version and Documentation

  • Chart version updated in Chart.yaml following semantic versioning
  • App version updated in Chart.yaml if applicable
  • artifacthub.io/changes section updated in Chart.yaml (see ArtifactHub annotation reference)
  • Variables are documented in the README.md (Corrects formatting in documentation/examples)

Testing and Validation

  • Ran ah lint locally without errors (A YAML syntax fix is covered by linting)
  • Ran Chart-Testing: ct lint --chart-dirs charts/n8n --charts charts/n8n --validate-maintainers=false
  • Tested chart installation locally
  • Tested with example configurations in /examples directory

Summary by CodeRabbit

  • Documentation
    • Improved readability by adjusting indentation in commented configuration examples related to webhook environment variables.
  • Style
    • Standardized indentation of commented configuration lines in chart values for consistent formatting and alignment.
  • Chores
    • Minor formatting cleanup to maintain consistency across configuration references.
  • Notes
    • No functional or behavioral changes; this update does not affect runtime behavior or user workflows.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Cosmetic indentation adjustments were made to commented lines related to webhook extraEnv/WEBHOOK_URL in README.md and charts/n8n/values.yaml. No configuration, behavior, or functional logic was changed.

Changes

Cohort / File(s) Summary
Documentation
README.md
Adjusted indentation in two commented lines under webhook extraEnv; no semantic or config changes.
Helm values
charts/n8n/values.yaml
Minor indentation change in commented WEBHOOK_URL line within webhook.extraEnv; alignment only, no functional impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the primary change of correcting indentation for extra environment variable examples, matching the actual modifications in both README.md and values.yaml without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec66f7c and 1dacaa7.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • charts/n8n/values.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weeix weeix marked this pull request as ready for review October 8, 2025 13:15
@Vad1mo Vad1mo merged commit e22d416 into 8gears:main Oct 9, 2025
3 of 4 checks passed
@weeix weeix deleted the fix-indent branch October 9, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants