build nix package from repo state instead of a pinned source-tarball#703
build nix package from repo state instead of a pinned source-tarball#703D4ndellion wants to merge 1 commit into9001:hovudstraumfrom
Conversation
|
I'm totally green on how the nix stuff works, but will this still be able to obtain the third-party dependencies which are built with deps-docker/Makefile and included in the tar.gz of each release? For example also pinging @chinponya since he was the mastermind behind the initial package and tends to have good ideas :> |
|
Ah, I didn't test the markdown editor, but you're right that it fails. It doesn't have any files in That means the nix package stuff isn't actually from source though.. So we have to fix that and package those deps properly |
|
Your assessment is correct @9001. This version will not contain web deps. |
Having packages pinned to a release like this is pretty unexpected for a nix user.
nix build github:9001/copyparty/<ref>should build the package referred to by that ref (a tag or commit hash or branch or whatever) not the last stable version at that point in timeI guess it was done like this because the package wasn't built from source anyways, but that's since been fixed 😃
This PR complies with the DCO; https://developercertificate.org/