Fix mfa_process compatibility issue on Windows #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows doesn't have /bin/sh - use cmd instead if executing an MFA command on windows.
|
I like this idea of a separate unix/windows Mfa process. Currently there is only a "solution" using WSL on Windows, which can be really slow. |
Mishco
approved these changes
Jul 2, 2025
mbevc1
reviewed
Jul 7, 2025
| @@ -0,0 +1,22 @@ | |||
| //go:build !windows | |||
There was a problem hiding this comment.
This probably needs to be: darwin || freebsd || openbsd || linux
|
Proposed feature looks good, would you mind opening a PR in the fork https://github.com/ByteNess/aws-vault ? |
|
Opened a PR in the fork and should be solved there: ByteNess#50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #1241 - windows doesn't have /bin/sh.
However, using cmd instead is also not quite straightforward since
exec.Commandhas some pitfalls on windows. This implements the suggested upstream workaround and allows us to launch mfa_process correctly on windows, even if the binary is in a path with spaces.