global subscription context config option#4237
Merged
Merged
Conversation
Signed-off-by: Steve Coffman <steve@khanacademy.org> # Conflicts: # codegen/field.go # codegen/internal!.gotpl # codegen/object.go # docs/content/reference/subscription-context.md # graphql/event.go # graphql/event_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add global subscription_context_field config option
This is PR for #3863 and is a follow-up to #4230
After #4230, @michelepra revised PR #4191 and added a PR comment that suggested that now the PR should be rebased on top of the implementation merged in #4230
However, that branch hadn't actually been rebased, but instead the latest
masterhad been merged into that branch, and then it appeared that an AI assistant had reconciled any conflicts and made a few other changes. However, the branch had a few problems, and still added more logic and complexity to the templates.Signed-off-by: Steve Coffman steve@khanacademy.org