Skip to content

🐛 Fixing problems with spaces in url #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vmadmax wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🐛 Fixing problems with spaces in url #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b90b89
:bug: Fixing problems with spaces in url
Vmadmax Dec 3, 2018
a31d9e8
:bug: Fixing failing tests
Vmadmax Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion lib/Thumbor/Url.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,29 @@ public function __construct($server, $secret, $original, $commands)
{
$this->server = $server;
$this->secret = $secret;
$this->original = $original;
$this->original = self::parseOriginalUrl($original);
$this->commands = $commands;
}

/**
* Produce a encoded URL.
* @param string $original URL of original image
* @return string
*/
private function parseOriginalUrl($original)
{
$scheme = parse_url($original, PHP_URL_SCHEME);
if ($scheme) {
$scheme .= '://';
$original = str_replace($scheme, '', $original);
}

$original = implode('/', array_map('rawurlencode', explode('/', $original)));
$original = $scheme . $original;

return $original;
}

/**
* Produce a URL to an image on a Thumbor server according to the specified
* options.
Expand Down