fix(ui): replace admin fallback with sign-in CTA on error pages#184
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the admin-oriented fallback action on shared error pages with a public sign-in CTA so recovery paths stay role-safe and aligned with the broader ReturnHub product experience.
Changes
templates/errors/403.htmlto replaceOpen Django adminwithGo to sign intemplates/errors/404.htmlto replaceOpen Django adminwithGo to sign intemplates/errors/500.htmlto replaceOpen Django adminwithGo to sign inReturn to landing pageprimary action on all shared error templatesrh-*UI structure intactWhy
The previous fallback action was technically valid, but it exposed an admin-oriented recovery path on shared public error pages used by customers, merchants, ops users, and anonymous visitors. Replacing it with a sign-in CTA keeps the recovery path broadly useful, better matches ReturnHub’s role-entry model, and avoids surfacing Django admin as the default fallback for non-admin audiences.
Validation
templates/errors/403.html,404.html, and500.htmlnow point toaccounts:login_merchantfor the secondary CTAui.error_viewsandconfig/urls.pyResult
Notes