Skip to content

fix: Add FlutterFramework to iOS SPM package#419

Merged
ABausG merged 1 commit into
ABausG:mainfrom
merlinnot:codex/spm-flutterframework
May 25, 2026
Merged

fix: Add FlutterFramework to iOS SPM package#419
ABausG merged 1 commit into
ABausG:mainfrom
merlinnot:codex/spm-flutterframework

Conversation

@merlinnot
Copy link
Copy Markdown
Contributor

Summary

  • add the local FlutterFramework package dependency to the iOS Swift Package manifest
  • link the home_widget target against the FlutterFramework product so Swift sources can resolve import Flutter when Flutter builds plugins through SPM

Validation

  • swift package dump-package --package-path packages/home_widget/ios/home_widget with a temporary local ../FlutterFramework link
  • git diff --cached --check

@docs-page
Copy link
Copy Markdown

docs-page Bot commented May 21, 2026

To view this pull requests documentation preview, visit the following URL:

docs.page/abausg/home_widget~419

Documentation is deployed and generated using docs.page.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

Walkthrough

The PR updates the Swift Package Manager manifest for home_widget to declare a dependency on FlutterFramework via a relative path and wires the home_widget target to use that product.

Changes

iOS Package Dependencies

Layer / File(s) Summary
FlutterFramework dependency wiring
packages/home_widget/ios/home_widget/Package.swift
Package manifest adds FlutterFramework as a dependency from ../FlutterFramework, and the home_widget target includes the FlutterFramework product in its dependencies.

Possibly related PRs

  • ABausG/home_widget#393: Both PRs update the iOS package setup around packages/home_widget/ios/home_widget/Package.swift as part of Swift Package Manager migration for the home_widget iOS plugin.

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides summary and validation details, but is missing required template sections including Description details, test/documentation/example checklist items, and breaking change assessment. Complete the required template sections: expand the Description section, mark all checklist items (tests, docs, examples, breaking change), and explicitly indicate which items are not applicable with [-] if needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: adding FlutterFramework as a dependency to the iOS Swift Package Manager package configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@merlinnot merlinnot changed the title fix: add FlutterFramework to iOS SPM package fix: Add FlutterFramework to iOS SPM package May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (55e6f43) to head (005054a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          175       175           
=========================================
  Hits           175       175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ABausG ABausG merged commit 85aa4bf into ABausG:main May 25, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants