Tweak om3 eval workflow #46
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aekiss any thoughts on this? |
|
@chrisb13 I'm confused - the PR commit removes most of the TODO section, which doesn't seem to be what you're proposing? |
|
Hi @aekiss, sorry for the confusion. The text was originally yours but I'm aware that we are now collecting quite a few diagnostics. Is it helpful to start thinking about how we collate results?
Also not sure if we want to have ideas about common parameters and the like, I imagine it's easier to define sooner rather than later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aekiss. It seems we're slowly getting a large collection of Figures (exciting!) Perhaps now is the time to flesh out the below TODOs?
In terms of the common parameters. I think papermill could be quite useful in this regard and might help make the workflow more run agnostic.
The idea is that we can discuss the plan in this PR (or a separate issue if you prefer)
ping @anton-seaice @minghangli-uni @anton-seaice @helenmacdonald if interested.
TODO
TODO: As we figure out the main results and develop the storyline, we can add to the Results_summary.md and Figure_outline.md.
TODO: define common parameters - e.g. see here