Skip to content

Conversation

@charles-turner-1
Copy link
Collaborator

Change Summary

Fix for https://forum.access-hive.org.au/t/intake-bug/5398, quite a lot simpler than what I was trying in #521. I don't think 521 can work because of the data model.

I haven't added variable_cell_methods to groupby_attrs yet - will require some testing first.

Related issue number

(https://forum.access-hive.org.au/t/intake-bug/5398)

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (c4028e9) to head (29f56cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   99.14%   99.08%   -0.07%     
==========================================
  Files          17       17              
  Lines        1516     1522       +6     
==========================================
+ Hits         1503     1508       +5     
- Misses         13       14       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-turner-1
Copy link
Collaborator Author

Unfortunately, this change breaks search on the intake-dataframe-catalog, either with or without groupby_attrs configured to include variable_cell_methods.

More digging required there first: from cosima-recipes/01-cooking-lessons-101/2-access-nri
-intake-catalog):

Screenshot 2025-10-27 at 10 37 40 am

@charles-turner-1
Copy link
Collaborator Author

Unfortunately, doesn't look like this will be resolved as a by product of fixing #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants