Skip to content

Conversation

@lbeckman314
Copy link
Contributor

@lbeckman314 lbeckman314 commented Apr 22, 2025

Warning

Work in Progress — currently resolving test failures below ⚠️

Overview 🌀

Cleaning up deprecated environments (e.g. development/staging) and resolving minor Pytest errors blocking successful GitHub Actions workflows

Current Behavior ❌

Current Actions are failing on deprecated environments (e.g. development/staging) as well as Pytest failures

New Behavior ✅

All actions succeed for:

  1. The external CALIPER environment at https://aced-idp.org (integration.yaml)
  2. All Pytest tests (pytest.yaml

@lbeckman314 lbeckman314 self-assigned this Apr 22, 2025
@lbeckman314 lbeckman314 added the bug Something isn't working label Apr 22, 2025
@lbeckman314 lbeckman314 requested a review from Copilot April 22, 2025 21:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up GitHub Actions workflows by removing deprecated environments and updating configurations to resolve workflow and pytest errors. Key changes include:

  • In .github/workflows/pytest.yaml, replacing the self‐hosted "cbds" configuration with an "external" environment and ubuntu-latest runner along with updating the endpoint.
  • In .github/workflows/main.yaml, renaming the "cbds" job to "external" and removing the staging and development jobs.
  • In .github/workflows/integration.yaml, updating the environment input description to reflect the new "external" and "internal" values.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/pytest.yaml Updated runner configuration and endpoint, switching from self‐hosted "cbds" to "external".
.github/workflows/main.yaml Renamed the job from "cbds" to "external" and removed deprecated job configurations.
.github/workflows/integration.yaml Revised the environment input description to list "external" and "internal".
Comments suppressed due to low confidence (3)

.github/workflows/pytest.yaml:20

  • The environment name 'external' replaces 'cbds'; please ensure that all related workflows and secret configurations are updated accordingly.
environment: external

.github/workflows/main.yaml:8

  • Renaming the job from 'cbds' to 'external' should be cross-checked with any upstream references to ensure consistent naming across workflows.
external:

.github/workflows/integration.yaml:25

  • Ensure that the updated description accurately reflects the supported environments in deployment; confirm that 'external' and 'internal' align with your overall configuration.
description: The target environment for this run (e.g. external, internal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants