Skip to content

Conversation

@thomash-acinq
Copy link
Member

@thomash-acinq thomash-acinq commented Jun 8, 2022

We estimate the probability that a given route can relay a given payment as part of route selection.
Until now this estimate was naively assuming the channel balances to be uniformly distributed.
We will now use data from past payment attempts (both successes and failures) to provide a better estimate, hopefully improving route selection.

@codecov-commenter
Copy link

Codecov Report

Merging #2308 (a834222) into master (3547f87) will decrease coverage by 0.05%.
The diff coverage is 90.47%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2308      +/-   ##
==========================================
- Coverage   85.87%   85.83%   -0.05%     
==========================================
  Files         215      215              
  Lines       17823    17826       +3     
  Branches      761      759       -2     
==========================================
- Hits        15306    15301       -5     
- Misses       2517     2525       +8     
Files Changed Coverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 92.99% <0.00%> (-0.30%) ⬇️
.../src/main/scala/fr/acinq/eclair/router/Graph.scala 97.00% <93.33%> (-0.34%) ⬇️
...cinq/eclair/remote/EclairInternalsSerializer.scala 97.82% <100.00%> (ø)
...scala/fr/acinq/eclair/router/BalanceEstimate.scala 98.91% <100.00%> (-0.03%) ⬇️
...cala/fr/acinq/eclair/router/RouteCalculation.scala 94.56% <100.00%> (ø)

... and 5 files with indirect coverage changes

@thomash-acinq thomash-acinq force-pushed the balance-estimate branch 3 times, most recently from 42b1635 to bc9253d Compare June 30, 2025 09:00
@thomash-acinq thomash-acinq marked this pull request as ready for review September 8, 2025 09:41
@thomash-acinq thomash-acinq requested a review from t-bast September 8, 2025 09:41
@thomash-acinq thomash-acinq merged commit d4dfb86 into master Sep 8, 2025
1 check passed
@thomash-acinq thomash-acinq deleted the balance-estimate branch September 8, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants