-
Notifications
You must be signed in to change notification settings - Fork 276
Implement "Simple Taproot Channels" BOLT proposal #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0082aea to
51ec562
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
+ Coverage 85.92% 86.38% +0.46%
==========================================
Files 219 220 +1
Lines 18488 19477 +989
Branches 794 814 +20
==========================================
+ Hits 15886 16826 +940
- Misses 2602 2651 +49
|
51ec562 to
cdefa9a
Compare
786cfa1 to
f9fe228
Compare
f9fe228 to
7480cee
Compare
37553dc to
1966835
Compare
46ef2b7 to
155b8dc
Compare
1966835 to
2015ced
Compare
452c0e0 to
16e75b0
Compare
2015ced to
c259402
Compare
57310de to
0ac5a45
Compare
c259402 to
537d134
Compare
0ac5a45 to
af1d5c7
Compare
537d134 to
22e6a8e
Compare
remyers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. I focused this preliminary review on splicing to identifiy any potential nonce reuse issues early.
I found one potential issue if we allow tx_abort after we send commit_sig.
I also think RBF of splices will need to be done carefully to avoid nonce resuse. I think we will need to include the RBF attempt count when generating nonces. I'll review again once you've rebased on the latest splice branch that includes splice RBF.
eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala
Outdated
Show resolved
Hide resolved
af1d5c7 to
5e9706a
Compare
cb1a0ff to
dc59336
Compare
5e9706a to
1926d8a
Compare
dc59336 to
799c1da
Compare
1926d8a to
f9fa5ba
Compare
1d85d22 to
258a479
Compare
4e6a55e to
827bcd9
Compare
827bcd9 to
6f023ff
Compare
f9fa5ba to
ca706c7
Compare
3dc1a34 to
6e1f9a9
Compare
ca706c7 to
65e74f6
Compare
6e1f9a9 to
ddd0c13
Compare
65e74f6 to
fe63e30
Compare
b7ff868 to
68aa9dc
Compare
fe63e30 to
a77aa5f
Compare
aae084e to
6afa679
Compare
6afa679 to
7eff6e5
Compare
d503971 to
e28b326
Compare
e28b326 to
5f21e96
Compare
This commit implements: - feature bits for simple taproot channels - TLV extensions for funding/closing wire messages - modifications to how we handle channel funding, splicing and mutual closing - changes to the commitment structures Since the current "simple taproot channels" proposal is not compatible with splices, we extend it to include a list of musig2 nonces (one for each active commitment transaction). Similar to how commitment points are handled, `firstRemoteNonce` and `secondRemoteNonce` fields have been added to `SpliceInit` and `SpliceAck`, encoded as a list of nonces (instead of 2 expicit nonces) We also need a nonce for the new commit tx that is being built, here it has been added to `SpliceInit` and `SpliceAck`. The closing workflow is similar to the standard "simple close" workflow: - Alice and Bob exchange `shutdown`, which includes a "closing nonce" (no changes here compared to the "simple taproot channels" spec). - Alice selects possible closing transaction (closer_output_only, closee_output_only, closer_and_closee_output) and for each of them creates a partial_signature_with_nonce using a new random local nonce and Bob's closing nonce (which she received in Bob's `shutdown` message). - Alice send a `closing_complete` message to Bob that include these partial_signature_with_nonce. - Bob receive Alice's `closing_complete` message, selects one of Alice's partial_signature_with_nonce, creates partial_signature_with_nonce using. his closing nonce and the nonce attached to the partial_signature_with_nonce and sends it to Alice in a `closing_sig` message. - Alice receives Bob's `closing_sig` and creates a partial signature for her closing tx using her closing nonce and the nonce attached Bob's partial_signature_with_nonce. - Alice combines this signature with Bob's and can broadcat her closing tx.
Upon re-connection, when a splice has not been fully completed, nodes will re-send signatures for the previous remote commit tx. This signature will be ignored by the receiving nodes if it has already received it before it was disconnected, simply by comparing them (signatures are deterministic). With taproot channels, we also need to attach musig2 nonces for splices in progress to channel_reestablish, which are needed to re-generate the signature for the old commit tx.
5f21e96 to
b11558f
Compare
|
closed in favour of #3005 |
This PR implements lightning/bolts#995 which introduces a new channel format where funding transactions send to an aggregated musig2 public key instead of a 2-of-2 multisig address:
Basic interop testing (opening/closing channels, sending/receiving payments) pass with lnd v0.18
The trickiest part of this PR is the update to the splicing protocol: splicing means that there can be multiple commitment transactions that are active at the same time, and signatures must be exchanged for all of them. With the new musig2-based funding transaction scheme, this means generating and exchanging musig2 nonces in advance, which requires modifications to the interactive tx and splicing protocols that are not (yet) covered by the BOLT proposal.
This is still a WIP, we also need to add support for simple taproot channels to https://github.com/ACINQ/lightning-kmp.
Based on #2896