Add basic liquidity purchase information to funding txs #2923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We record whether a liquidity purchase happened as part of every funding transaction with the purchased amount and fees. We don't record how the payment was made, because: - it creates more backwards-compatibility risk if the liquidity ads spec changes - it's most likely unnecessary once the purchase happened, and can only be stored in the liquidity DB for auditing
pm47
approved these changes
Oct 11, 2024
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LiquidityAds.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We record whether a liquidity purchase happened as part of every funding transaction with the purchased amount and fees. We don't record how the payment was made, because: