Make option_channel_type mandatory #3046
Merged
+24
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step before we make the change to always assume option_channel_type. see lightning/bolts#1232 Removed tests that depend on a node without the option_channel_type feature set. Updated some tests that must explicitly set the init features to include option_channel_type.
remyers
force-pushed
the
mandatory_channel_type
branch
from
5563613 to
2b77e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step before we make the change to always assume option_channel_type.
See lightning/bolts#1232
Removed tests that depend on a node without the option_channel_type feature set.
Updated some tests that must explicitly set the init features to include option_channel_type.