Fix reconnection to clearnet addresses via Tor

[rorp]

Fixes #3051

[t-bast]

At first glance, this seems to be incorrect: it will incorrectly use Tor in some configurations. But I'll need to spend more time looking at this again and how we configure it to be sure.

@sstone does that ring a bell? I'm pretty sure we had these distinct cases for a good reason.

[sstone]

The proposed change do not check useForIPv4 and useForIPv6 anymore which does seem wrong. I commented on the linked issue which describes 2 different problems (the first one being the expected behaviour when the socks5 proxy is configured to handle all connections).

[rorp]

At first glance, this seems to be incorrect

It appears to be a logical approach. When outgoing Tor connections are disabled, we are effectively unable to connect to Tor addresses, so we default to selecting only clearnet addresses.

Conversely, if Tor connections are enabled, we consider all available addresses - both Tor and clearnet - and randomly select one. Client actor then establishes a connection to the chosen address via either Tor or clearnet, depending on the configuration settings.

[rorp]

It can be incorrect if use-for-tor is set to false. In this case, even if Tor is enabled, it will attempt to connect to Tor addresses via clearnet, which doesn't make sense at all.

I think we can remove use-for-tor configuration parameter.

[rorp]

It can be incorrect if use-for-tor is set to false. In this case, even if Tor is enabled, it will attempt to connect to Tor addresses via clearnet, which doesn't make sense at all.

I added a handler for this unlikely case, too.

[t-bast]

@sstone can you take another look at this?

[rorp]

Any updates about this fix? I had to manually patch the second major release to have a usable Eclair version...

[t-bast]

@sstone will look into it shortly, we've been busy with taproot work but should have time to finalize this next week. Sorry for the delay.

[sstone]

I think your reasoning makes sense but I added a comment because it was not really obvious: the decision to use a proxy or not is made later when we try to connect, so we should only filter out addresses that we know we won't able to connect to, and it's only true for tor addresses when we don't have a proxy with useForTor set.

I checked our documentation and it does not need to be updated.