Add an option to specify a custom signet tx to check #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables custom signets by allowing the user to specify the txid of a transaction to check or "" to skip this check for signet. See issue ACINQ#3078.
t-bast
reviewed
May 19, 2025
There was a problem hiding this comment.
LGTM, that sounds like a flexible enough solution! I think we should also modify README.md, where we have a small section around signet usage. We should mention this configuration value to let users quickly figure out that they may need to set this when using non-default signet.
|
I added some verbage around the new signet config parameter in 6ba374c. |
remyers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables custom signets by allowing the user to specify the txid of a transaction to check or "" to skip this check for signet. Fixes issue #3078.