Skip to content

Add attribution data to UpdateFulfillHtlc #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomash-acinq
Copy link
Member

Attribution data is added to both failed and fulfilled HTLCs
lightning/bolts#1044

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.96%. Comparing base (f14b92d) to head (9e22800).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
.../scala/fr/acinq/eclair/payment/PaymentPacket.scala 50.00% 4 Missing ⚠️
...src/main/scala/fr/acinq/eclair/crypto/Sphinx.scala 96.87% 1 Missing ⚠️
...r/acinq/eclair/payment/relay/OnTheFlyFunding.scala 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
+ Coverage   85.80%   85.96%   +0.16%     
==========================================
  Files         236      237       +1     
  Lines       21299    21557     +258     
  Branches      859      825      -34     
==========================================
+ Hits        18275    18532     +257     
- Misses       3024     3025       +1     
Files with missing lines Coverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala 100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala 100.00% <ø> (ø)
...in/scala/fr/acinq/eclair/channel/Commitments.scala 95.63% <100.00%> (-0.51%) ⬇️
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 83.15% <100.00%> (+0.05%) ⬆️
...cinq/eclair/payment/receive/MultiPartHandler.scala 93.90% <100.00%> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala 96.53% <100.00%> (+0.06%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 94.33% <100.00%> (ø)
.../eclair/payment/relay/PostRestartHtlcCleaner.scala 88.77% <100.00%> (+0.05%) ⬆️
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala 100.00% <100.00%> (ø)
...fr/acinq/eclair/wire/protocol/FailureMessage.scala 80.21% <100.00%> (+0.67%) ⬆️
... and 5 more

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thomash-acinq thomash-acinq force-pushed the attributable-success branch from 9e22800 to 56c7cc8 Compare June 5, 2025 13:13
@thomash-acinq thomash-acinq marked this pull request as ready for review June 5, 2025 13:14
@thomash-acinq thomash-acinq requested a review from t-bast June 5, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants