Skip to content

Check that relay fees are nonnegative #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomash-acinq merged 1 commit into from
Nov 5, 2025
Merged

Check that relay fees are nonnegative #3209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions eclair-node/src/main/scala/fr/acinq/eclair/api/handlers/Fees.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

package fr.acinq.eclair.api.handlers

import akka.http.scaladsl.server.Route
import akka.http.scaladsl.server.{Route, ValidationRejection}
import fr.acinq.eclair.MilliSatoshi
import fr.acinq.eclair.api.Service
import fr.acinq.eclair.api.directives.EclairDirectives
Expand All @@ -36,7 +36,11 @@ trait Fees {
val updateRelayFee: Route = postRequest("updaterelayfee") { implicit t =>
withNodesIdentifier { nodes =>
formFields("feeBaseMsat".as[MilliSatoshi], "feeProportionalMillionths".as[Long]) { (feeBase, feeProportional) =>
complete(eclairApi.updateRelayFee(nodes, feeBase, feeProportional))
if (feeBase.toLong < 0 || feeProportional < 0) {
reject(ValidationRejection("Fees must be nonnegative"))
} else {
complete(eclairApi.updateRelayFee(nodes, feeBase, feeProportional))
}
}
}
}
Expand Down