Skip to content

Conversation

@ekzyis
Copy link
Contributor

@ekzyis ekzyis commented Nov 23, 2025

Hello!

I noticed that the links to 'Reaching The Ground With Lightning' in README.md and CONTRIBUTING.md were broken because the file was moved in ElementsProject/lightning@9e47c16.

I now used a permalink so the links will not break again. However, that also means if the PDF gets updated, the links will still point to the old version.

However, since the PDF has not been changed meaningfully in 10 years (last time in ElementsProject/lightning@2ab9e3b), I don't think that's ever going to happen again.

But if it happens, I think working links are more important anyway.

I also searched for deployable-lightning.pdf to check if there's another broken link, but I didn't find any.

@ekzyis ekzyis force-pushed the fix-link-in-resources branch from d3f8f9a to 8ac4757 Compare November 23, 2025 14:55
@ekzyis ekzyis changed the title Fix link to 'Reaching The Ground With Lightning' Fix links to 'Reaching The Ground With Lightning' Nov 23, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (f93d02f) to head (8ac4757).
⚠️ Report is 57 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
+ Coverage   86.43%   88.94%   +2.50%     
==========================================
  Files         242      218      -24     
  Lines       22607    20500    -2107     
  Branches      832      800      -32     
==========================================
- Hits        19541    18233    -1308     
+ Misses       3066     2267     -799     

see 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pm47 pm47 merged commit e1775ee into ACINQ:master Dec 4, 2025
1 check passed
@ekzyis ekzyis deleted the fix-link-in-resources branch December 4, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants