Implement option_simple_close
#597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
option-simple-close
branch
from
79f3e0e to
48b7348
Compare
t-bast
force-pushed
the
option-simple-close
branch
2 times, most recently
from
7b7e5ae to
433fc10
Compare
t-bast
force-pushed
the
option-simple-close
branch
2 times, most recently
from
c0d3dc1 to
c650799
Compare
t-bast
force-pushed
the
option-simple-close
branch
3 times, most recently
from
737819a to
f379f68
Compare
The spec allows the closer to use an OP_RETURN output if their amount is too low when using `option_simple_close`.
We update the `Negotiating` state to exchange the `closing_complete` and `closing_sig` messages, and allow RBF-ing previous transactions and updating our closing script. We stay in that state until one of the transactions confirms, or a force close is detected. This is important to ensure we're able to correctly reconnect and negotiate RBF candidates.
t-bast
force-pushed
the
option-simple-close
branch
from
f379f68 to
db7b908
Compare
pm47
reviewed
Mar 18, 2025
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
LGTM.
Tested against eclair in nominal and RBF cases.
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/Helpers.kt
Show resolved
Hide resolved
sstone
reviewed
Mar 18, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/Helpers.kt
Outdated
Show resolved
Hide resolved
We add a completable `replyTo` to the mutual close command, which returns the closing `txId` and its fees once signed by our peer. This requires waiting for HTLCs to be settled before we can move to the closing state and exchange signatures.
Instead of partially storing parts of the command in the various channel states, we directly store the whole command. This makes it easier to detect whether we initiated closing or if the remote node did.
pm47
approved these changes
Mar 20, 2025
sstone
approved these changes
Mar 20, 2025
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
option_simple_closeas defined in lightning/bolts#1205This is a pre-requisite for taproot channels that is already supported by
eclair.