Skip to content

Conversation

@thomash-acinq
Copy link
Member

We use peer storage (lightning/bolts#1110) for channel backups.
We also keep the legacy channel data backup for some transition period.
Requires ACINQ/eclair#2888 on eclair's side.

We also keep the legacy channel data backup for some transition period.
@t-bast
Copy link
Member

t-bast commented Oct 23, 2024

A note regarding backwards-compatibility: I think we don't need any kind of backwards-compat in lightning-kmp, we can do everything on the eclair side (where we need backwards-compat anyway because we need to keep working with wallets that haven't updated.

The way I think it should work is:

  • in lightning-kmp, you can completely remove the old channelData TLV and only use the new backup messages
  • on the eclair side, we can simply:
    • always store backup data, regardless of where it comes from (the channelData TLV or the new backup messages)
    • whenever we connect to a mobile wallet:
      • if they have the feature bit for the new backup protocol, we send them their backup using the new messages
      • otherwise, we include it in the channelData field of our channel_reestablish

Does that make sense? It seems like it should be quite simple to provide a smooth transition that way (and eventually phase out the channelData TLV field on the eclair side after 6 months or 1 year).

@t-bast
Copy link
Member

t-bast commented Jan 23, 2025

Closing in favor of #723

@t-bast t-bast closed this Jan 23, 2025
@t-bast t-bast deleted the dual-peer-storage branch January 23, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants