Refactor transactions for taproot compatibility #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
commented
Jul 29, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/blockchain/electrum/SwapInManager.kt
Show resolved
Hide resolved
t-bast
force-pushed
the
refactor-transactions-and-commitment
branch
2 times, most recently
from
dbe527d to
f4b78c0
Compare
t-bast
force-pushed
the
refactor-transactions-and-commitment
branch
from
a2c8b09 to
2e950c7
Compare
t-bast
force-pushed
the
refactor-transactions-and-commitment
branch
from
8773063 to
ba12721
Compare
We refactor our transactions handling and our closing data to match the changes made in `eclair` to support taproot channels and commitment upgrades during splices. The architecture matches the change made in eclair, up to changes from ACINQ/eclair#3118
t-bast
force-pushed
the
refactor-transactions-and-commitment
branch
from
ba12721 to
397fef5
Compare
pm47
reviewed
Oct 1, 2025
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
LGTM:
- consistent with the eclair data model
- end-to-end tests pass against eclair
pm47
approved these changes
Oct 1, 2025
sstone
added a commit
that referenced
this pull request
Oct 8, 2025
#800 included a lot of improvements on our data structure and removed data that was either redondant or could be re-computed. This means that serialised channel states are smaller, and we can increase the number of pending HTLCs to 18 and stay below the 65 Kb size limit for LN messages. Note that this applies to new channels only: existing ones will still use the previous value of 12 pending HTLCs.
sstone
added a commit
that referenced
this pull request
Oct 9, 2025
#800 included a lot of improvements on our data structure and removed data that was either redondant or could be re-computed. This means that serialised channel states are smaller, and we can increase the number of pending HTLCs to 18 and stay below the 65 Kb size limit for LN messages. Note that this applies to new channels only: existing ones will still use the previous value of 12 pending HTLCs.
sstone
added a commit
that referenced
this pull request
Oct 9, 2025
#800 included a lot of improvements on our data structure and removed data that was either redondant or could be re-computed. This means that serialised channel states are smaller, and we can increase the number of pending HTLCs to 18 and stay below the 65 Kb size limit for LN messages. Note that this applies to new channels only: existing ones will still use the previous value of 12 pending HTLCs.
sstone
added a commit
that referenced
this pull request
Oct 9, 2025
#800 included a lot of improvements on our data structure and removed data that was either redondant or could be re-computed. This means that serialised channel states are smaller, and we can increase the number of pending HTLCs to 18 and stay below the 65 Kb size limit for LN messages. Note that this applies to new channels only: existing ones will still use the previous value of 12 pending HTLCs.
ebonyschneider462359
added a commit
to ebonyschneider462359/lightning-kmp
that referenced
this pull request
Oct 10, 2025
ACINQ/lightning-kmp#800 included a lot of improvements on our data structure and removed data that was either redondant or could be re-computed. This means that serialised channel states are smaller, and we can increase the number of pending HTLCs to 18 and stay below the 65 Kb size limit for LN messages. Note that this applies to new channels only: existing ones will still use the previous value of 12 pending HTLCs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refactor our transactions handling and our closing data to match the changes made in
eclairto support taproot channels and commitment upgrades during splices.The architecture matches the change made in eclair, up to changes from ACINQ/eclair#3118