Use bitcoin-kmp 0.26.0 #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitcoin-kmp 0.26.0 uses secp256k1-kmp 0.19.0 which includes ACINQ/secp256k1-kmp#126.
t-bast
reviewed
Sep 19, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/InteractiveTx.kt
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Sep 22, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/InteractiveTx.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonTest/kotlin/fr/acinq/lightning/transactions/TransactionsTestsCommon.kt
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitcoin-kmp 0.26.0 uses secp256k1-kmp 0.19.0 which includes ACINQ/secp256k1-kmp#126.
There are no functional changes, but there is a new method for Musig2 nonce generation (see ACINQ/bitcoin-kmp#161) and the old one has been deprecated which will trigger a compile warning that will affect
bitcoin-lib(but probably noteclairorphoenix/phoenixd).