Add more logs around commit_sig
#834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a few force-close caused by invalid commit_sig messages. This may happen when multiple devices are used in parallel, but some reports don't seem to be using multiple devices. Unfortunately, we didn't log the details of the commit tx we're building in every case. Also, we only logged details of our local commit tx after validating the remote `commit_sig`, which means we cannot troubleshoot the case where we reject that remote `commit_sig`. We now log details of the commit tx construction in every scenario, which should allow detecting discrepancies between the local and remote states.
pm47
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few force-close caused by invalid
commit_sigmessages. This may happen when multiple devices are used in parallel, but some reports don't seem to be using multiple devices.Unfortunately, we didn't log the details of the commit tx we're building in every case. Also, we only logged details of our local commit tx after validating the remote
commit_sig, which means we cannot troubleshoot the case where we reject that remotecommit_sig.We now log details of the commit tx construction in every scenario, which should allow detecting discrepancies between the local and remote states.