Improve logs during reconnection #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing, even though it does what we expect.
This helps figure out reconnection issues where the splice state doesn't match. We also include more logs in a few related places.
We aren't consistent with regards to updating the `_channels` map and calling `processActions`: sometimes we do it first, sometimes second. It's really hard to reason about this and figure out whether this may have side effects or not, but it seems more consistent to update the channel state first, then process its follow-up actions.
The funding indices should be enough.
pm47
reviewed
Nov 5, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/logging/MDCLogger.kt
Show resolved
Hide resolved
pm47
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to analyze logs of de-synchronized on-the-fly splices, I got stuck because the
OfflineandSyncingstates don't contain enough details about the state of the channel's commitments. I'm adding that to the MDC.The issue seems to be related to frequent disconnections/reconnections happening while the signing step is in-progress, and it looks as if at some point, some of the channel state was rolled back, but I can't figure out why without more logs...
This PR contains several independent commits, they are best reviewed separately.