Compact offer thomas #841
Compact offer thomas #841
Conversation
| } | ||
| } | ||
|
|
||
| data class CardPaymentRequest(val tlvs: TlvStream<OfferTypes.OfferTlv>) : OnionMessagePayloadTlv() { |
There was a problem hiding this comment.
@robbiehanson in your last email you wrote that CardPaymentRequest includes an Invoice. I think it makes more sense to include an Offer and reuse the existing offer payment pipeline.
I'll let you add the authentication data from the card.
There was a problem hiding this comment.
I think it makes more sense to include an Offer and reuse the existing offer payment pipeline.
The community does NOT want to go this route.
One of the most important benchmarks for card payments is speed. If the CardPaymentRequest directly includes an invoice, then the entire process is only 2 steps (send CardPaymentRequest, receive payment). Changing this to an offer increases the process to 4 steps, thus doubling the payment time.
Also, a lot of software is built on top of LND, and LND doesn't have full Bolt 12 support yet. So the community is asking for flexibility. Specifically, they want CardPaymentRequest to support sending either a Bolt 12 or 11 invoice.
I have a branch called card-payment which has a working proof-of-concept. But the spec is still very much a work in progress. So I was hoping to avoid dealing with the CardPaymentRequest details in this PR. Is it possible to skip including this for now, and circle back to it in a later PR ?
This reverts commit 2cedfb8.
No description provided.