Skip to content

Update secp256k1 submodule #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sstone merged 6 commits into from
Nov 20, 2024
Merged

Update secp256k1 submodule #107

sstone merged 6 commits into from
Nov 20, 2024

Conversation

@sstone
Copy link
Member

@sstone sstone commented Mar 11, 2024

Counter-based nonce generation has been extracted into a separate method.

@sstone sstone force-pushed the snapshot/update-secp256k1 branch 2 times, most recently from e23a77b to 2a3badd Compare April 22, 2024 16:28
@sstone sstone force-pushed the snapshot/update-secp256k1 branch from 565a679 to 62afbc8 Compare June 6, 2024 08:03
@sstone sstone marked this pull request as ready for review June 6, 2024 12:49
@t-bast
Copy link
Member

t-bast commented Jun 6, 2024

I don't think we need to merge any update to the libsecp256k1 submodule until they officially ship musig2. I'd rather wait for the musig2 PR to be merged on their side before we update to a "final" version.

@sstone
Copy link
Member Author

sstone commented Jun 6, 2024

We can wait. The musig2 branch that we use is behind secp2561k1's musig2 PR but there are only minor changes and an API change (counter-based nonce generation). I hope it will be released soon though :)

@ChrisSon15 ChrisSon15 mentioned this pull request Jul 13, 2024
Open
@sstone sstone force-pushed the snapshot/update-secp256k1 branch from 7b1e117 to c5b66d3 Compare September 17, 2024 17:00
@sstone sstone requested a review from t-bast October 8, 2024 07:59
@sstone sstone added this to the 0.16.0 milestone Nov 4, 2024
@sstone sstone force-pushed the snapshot/update-secp256k1 branch from cea19a3 to 453fceb Compare November 7, 2024 10:28
t-bast
t-bast reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, we should make a release now that we depend on an official release of secp256k1! However it looks like you're still pointing the submodule to jonasnick's fork of the repository, can you fix it and point it to https://github.com/bitcoin-core/secp256k1?

@sstone
Copy link
Member Author

sstone commented Nov 20, 2024

Looks mostly good to me, we should make a release now that we depend on an official release of secp256k1! However it looks like you're still pointing the submodule to jonasnick's fork of the repository, can you fix it and point it to https://github.com/bitcoin-core/secp256k1?

Done in 6a68a9d

@sstone sstone merged commit 9d080e9 into master Nov 20, 2024
6 checks passed
@sstone sstone deleted the snapshot/update-secp256k1 branch November 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-bast t-bast t-bast approved these changes

Assignees

@t-bast t-bast

Labels

None yet

Projects

None yet

Milestone

0.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sstone @t-bast