Swtich tile Done #293
Open
Swtich tile Done #293
+244
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @up4154, for opening the pull request! 🙌 |
Member
|
Please attach screen recording of the same. |
Member
|
Also please sync your work to solve conflicts. |
Contributor
Author
SwtichList.Tile.mp4 |
Member
|
Why did you close the PR? |
Member
AryanKhubchandani
left a comment
AryanKhubchandani
left a comment
There was a problem hiding this comment.
A few changes are required:
- Add more tiles
- As mentioned in the issue #280, please showcase properties like activeThumbImage and secondary
Contributor
Author
|
ok i will do the changes |
Contributor
Author
SwtichList.Tile.mp4 |
AryanKhubchandani
requested changes
Oct 26, 2021
Member
AryanKhubchandani
left a comment
AryanKhubchandani
left a comment
There was a problem hiding this comment.
Some more changes are required:
- You have removed some content from the README, so please revert the changes you made in README
- Don't use hardcore values, use ThemeData
- Fix the spelling of switch in the third listTile
Contributor
Author
|
Changes done |
AryanKhubchandani
requested changes
Oct 27, 2021
Member
AryanKhubchandani
left a comment
AryanKhubchandani
left a comment
There was a problem hiding this comment.
You have removed ImageFilter Widget from the widgetList.dart file and also removed the imports of image_filtered.dart and tooltip.dart. Please fix this so that I can merge your PR.
Member
|
Please update regarding the PR for it to be considered to be hacktoberfest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.