Skip to content

Swtich tile Done #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Swtich tile Done #293

wants to merge 16 commits into from

Conversation

up4154
Copy link
Contributor

@up4154 up4154 commented Oct 23, 2021

No description provided.

@acmbot
Copy link

acmbot bot commented Oct 23, 2021

Thanks @up4154, for opening the pull request! 🙌
One of our team-mates will review the pull request soon. ✅

@AryanKhubchandani
Copy link
Member

Please attach screen recording of the same.

@AryanKhubchandani
Copy link
Member

Also please sync your work to solve conflicts.

@AryanKhubchandani AryanKhubchandani linked an issue Oct 24, 2021 that may be closed by this pull request
Add SwitchListTile Widget to the Widget Catalog #280
Open
@up4154
Copy link
Contributor Author

up4154 commented Oct 25, 2021

SwtichList.Tile.mp4

@up4154 up4154 closed this Oct 25, 2021
@AryanKhubchandani
Copy link
Member

Why did you close the PR?

AryanKhubchandani
AryanKhubchandani reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@AryanKhubchandani AryanKhubchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are required:

  1. Add more tiles
  2. As mentioned in the issue Add SwitchListTile Widget to the Widget Catalog #280, please showcase properties like activeThumbImage and secondary

@up4154
Copy link
Contributor Author

up4154 commented Oct 26, 2021

ok i will do the changes

@up4154
Copy link
Contributor Author

up4154 commented Oct 26, 2021

SwtichList.Tile.mp4

AryanKhubchandani
AryanKhubchandani requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@AryanKhubchandani AryanKhubchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes are required:

  1. You have removed some content from the README, so please revert the changes you made in README
  2. Don't use hardcore values, use ThemeData
  3. Fix the spelling of switch in the third listTile

@up4154
Copy link
Contributor Author

up4154 commented Oct 27, 2021

Changes done

AryanKhubchandani
AryanKhubchandani requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@AryanKhubchandani AryanKhubchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have removed ImageFilter Widget from the widgetList.dart file and also removed the imports of image_filtered.dart and tooltip.dart. Please fix this so that I can merge your PR.

@AryanKhubchandani
Copy link
Member

Please update regarding the PR for it to be considered to be hacktoberfest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AryanKhubchandani AryanKhubchandani AryanKhubchandani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SwitchListTile Widget to the Widget Catalog
2 participants
@up4154 @AryanKhubchandani