Installation #22
Merged
Installation #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
msyriac
approved these changes
Mar 25, 2025
Member
|
Code changes look good to me; thanks Antony! CI is failing though.. |
Collaborator
Author
|
I guess you need to cobaya-install it before running the cobaya test, since the non-cobaya tests do not install into the cobaya packages folder. The mac fails seem to be nothing to do with this PR. |
Member
|
Ok that requires editing the workflow files: I'm not sure I can edit them in this PR since it's from your fork's main branch. I'll merge this into a devel branch. |
msyriac
added a commit
that referenced
this pull request
Mar 28, 2025
* Installation (#22) * cobaya install * cobaya install * try cobaya install for tests * Update testing.yml * class name in cobaya install * add pip install of checked out module * update miniconda action --------- Co-authored-by: Antony Lewis <[email protected]> Co-authored-by: Ian Harrison <[email protected]>
msyriac
added a commit
that referenced
this pull request
Apr 4, 2025
* Installation (#22) * cobaya install * cobaya install * try cobaya install for tests * Update testing.yml * class name in cobaya install * add pip install of checked out module * update miniconda action * add publish workflow --------- Co-authored-by: Antony Lewis <[email protected]> Co-authored-by: Mathew Madhavacheril <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of how to install (of course it would be much cleaner to make cobaya a dependency, and use the cobaya mechanism rather than having custom install routines, and pull all functions as class methods).
(sorry about all the whitespace changes, did an auto-format)