ADDING SMAC3 to Sparkle #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thijssnelleman
commented
Nov 15, 2024
thijssnelleman
commented
- Created SMAC3 class to handle configuration calls
- Created SMAC3 scenario class to wrap around smac.scenario.Scenario class
- Created TargetRunner subclass for Sparkle to make sure solver metrics are done through RunSolver and not Python.time lib or Pynisher.
- Added all scenario parameters to be able to set through Sparkle
- Added one non-scenario parameter (Initial design parameter) max_ratio
- Set smac facade to be user-configurable
- Added several unittests
- Verified configure solver for runtime example works (Improved about one order size compared to SMAC2 with same budget)
- Still lacks platform support to make use of SMAC3 MO capabilities
- SMAC3 lacks support to differentiate between Wall and CPU time
jeroenrook
requested changes
Dec 2, 2024
sparkle/types/__init__.py
Outdated
| """Try to resolve the objective class by (case-sensitive) name. | ||
| convention: objective_name(variable-k)?(:[min|max])? | ||
| convention: objective_name(variable-k)?(:[min|max])?(:metric)? |
Collaborator
There was a problem hiding this comment.
Add to doctoring the difference between metric and objective. + convention does not align with regex in line 15
Member
Author
There was a problem hiding this comment.
Not one hundred percent sure what is meant here, but updating docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.