Skip to content

Conversation

@thijssnelleman
Copy link
Member

Mainly changed the readme and the location of the auto complete script. There is no autocomplete script for Conda for now.

…t instead of conda. Updating how autocomplete must be installed.
@jd-rub
Copy link

jd-rub commented Sep 30, 2025

Looks reasonable for venv. One concern re: version compatibility.
You're pulling the most recent version of the script which might break if someone uses an older Sparkle version and the script gets somehow updated in the future. Is there any reason to not just have a local copy in the repo?

@thijssnelleman
Copy link
Member Author

thijssnelleman commented Sep 30, 2025

Yes, this would mean the script is shipped with the package through pip although it serves no other purpose than being injected into this activate script. Thus, I prefer to download it separately afterwards to avoid file clutter with the installation where possible.

Copy link

@jd-rub jd-rub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty.

@thijssnelleman thijssnelleman merged commit 1ec9951 into development Oct 1, 2025
5 checks passed
@thijssnelleman thijssnelleman deleted the replace-conda-with-venv branch October 1, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants