Feature/6 lightbridge authz helm chart #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Franck-Sorel
requested review from
Dericko681,
Koufan-De-King,
benie-joy-possi,
marcjazz and
stephane-segning
Franck-Sorel
force-pushed
the
feature/6-lightbridge-authz-helm-chart
branch
from
111b129 to
32ba111
Compare
This was
linked to
issues
Oct 15, 2025
Dericko681
requested changes
Oct 15, 2025
Franck-Sorel
force-pushed
the
feature/6-lightbridge-authz-helm-chart
branch
from
f5109a6 to
6038781
Compare
- Fixed ClientTrafficPolicy template to use proper targetRefs array structure - Corrected enableProxyProtocol to be boolean instead of nested object - Removed invalid 'connection' field not supported in ClientTrafficPolicy API - Updated values.yaml to match template expectations with proper nesting - Set dynamic namespace using .Release.Namespace with default fallback - Simplified template by removing unnecessary common.tplvalues.render calls The template now generates valid ClientTrafficPolicy manifests that comply with Envoy Gateway v1.4+ API specifications, resolving previous installation failures and template evaluation errors.
Franck-Sorel
force-pushed
the
feature/6-lightbridge-authz-helm-chart
branch
from
6038781 to
4165bac
Compare
This commit updates the `lightbridge-authz-umbrella` chart to correctly use
the refactored `lightbridge-authz` and `lightbridge-config` subcharts as
local dependencies.
Key changes include:
- **Local Dependency Resolution:**
- Updated `Chart.yaml` and `Chart.lock` to reference subcharts via local
file paths (`file://../<chart-name>`), ensuring the umbrella chart uses
the latest local versions instead of remote ones.
- **Values Overrides for `lightbridge-authz`:**
- Reorganized `values.yaml` overrides to align with the new
`app-template`-based structure.
- Added `enabled: true` and `app-template.enabled: true` to ensure proper
rendering of both the subchart and its dependency.
- **Values Cleanup for `lightbridge-config`:**
- Removed obsolete and unused overrides, resulting in a cleaner and more
maintainable `values.yaml`.
These updates ensure consistent deployment across the umbrella chart and its
refactored subcharts.
Franck-Sorel
requested review from
benie-joy-possi
and removed request for
Koufan-De-King,
benie-joy-possi and
marcjazz
Dericko681
requested changes
Oct 17, 2025
Dericko681
requested changes
Oct 17, 2025
Dericko681
requested changes
Oct 17, 2025
This commit updates the descriptions in the `Chart.yaml` files for the `lightbridge-authz-umbrella`, `lightbridge-authz`, and `lightbridge-config` charts. The new descriptions provide a more detailed explanation of the purpose and function of each chart, improving the overall clarity and maintainability of the Helm release. - **lightbridge-authz-umbrella**: Now clearly described as the main entry point for deploying the entire Lightbridge authorization system. - **lightbridge-authz**: Description updated to highlight its role as the core authorization service. - **lightbridge-config**: Description updated to explain its responsibility for managing authorization policies, networking, and security configurations.
|
Don't forget to work on the linting errors we get when running the lint helm chart workflow |
Koufan-De-King
requested changes
Oct 21, 2025
There was a problem hiding this comment.
I would like this to be better documented, especially how to test and get the same results–including reasons for the method of testing being valid and not casuing issues for actual prod deployment.
Also, explaining how the secrets are getting injected into our k8s cluster and then our self-service application would be great too.
… lightbridge-config charts
Koufan-De-King
approved these changes
Oct 21, 2025
…ndard Helm functions - Remove Bitnami common chart dependency from Chart.yaml - Refactor test-connection.yaml to use native Helm template functions - Update external config documentation files"
Dericko681
requested changes
Oct 22, 2025
…idge-config chart - Deleted guard-securitypolicy.yaml, ratelimit.yaml, retry.yaml, rl-local-burst.yaml, route.yaml, and test.yaml templates. - Removed associated values from values.yaml, including rate limit policies and model configurations. - Cleaned up unused backend traffic policies and security policies to streamline the chart.
stephane-segning
requested changes
Oct 24, 2025
There was a problem hiding this comment.
Remove this keycloak, or make it modular
There was a problem hiding this comment.
Modular in the sense of configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local Test ran successfully !
Closes #11