chore(): added modules from ai-ops #27
Conversation
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
@codex please review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type: choice | ||
| options: | ||
| - dev | ||
| - prod | ||
| pull_request: null |
There was a problem hiding this comment.
Adding the pull_request event causes this workflow to run without inputs.environment, yet later steps still rely on that input for environment naming and for terraform init -var-file=${{ inputs.environment }}.tfvars. On a pull request run, this expression evaluates to an empty string, so Terraform is invoked with a non-existent .tfvars file and the job fails before planning. Either supply a default environment for PR runs or skip these steps when the workflow wasn’t dispatched with an explicit input.
Useful? React with 👍 / 👎.
| OPENID_CLIENT_SECRET = var.keycloak_client_secret | ||
| OPENID_SESSION_SECRET = random_string.social_session_secret.result | ||
|
|
||
| # USE_REDIS = "true" | ||
| REDIS_URI = var.redis_uri |
There was a problem hiding this comment.
The kubernetes_secret uses the data attribute with raw strings, including values such as REDIS_URI = var.redis_uri that contain characters like ://. The Kubernetes provider expects data values to be base64 encoded, so applying this module will fail with an “illegal base64 data” error and the secret is never created. Use the string_data attribute or wrap each value in base64encode(...) before assigning to data.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type: choice | ||
| options: | ||
| - dev | ||
| - prod | ||
| pull_request: null |
There was a problem hiding this comment.
Adding the pull_request event causes this workflow to run without inputs.environment, yet later steps still rely on that input for environment naming and for terraform init -var-file=${{ inputs.environment }}.tfvars. On a pull request run, this expression evaluates to an empty string, so Terraform is invoked with a non-existent .tfvars file and the job fails before planning. Either supply a default environment for PR runs or skip these steps when the workflow wasn’t dispatched with an explicit input.
Useful? React with 👍 / 👎.
| OPENID_CLIENT_SECRET = var.keycloak_client_secret | ||
| OPENID_SESSION_SECRET = random_string.social_session_secret.result | ||
|
|
||
| # USE_REDIS = "true" | ||
| REDIS_URI = var.redis_uri |
There was a problem hiding this comment.
The kubernetes_secret uses the data attribute with raw strings, including values such as REDIS_URI = var.redis_uri that contain characters like ://. The Kubernetes provider expects data values to be base64 encoded, so applying this module will fail with an “illegal base64 data” error and the secret is never created. Use the string_data attribute or wrap each value in base64encode(...) before assigning to data.
Useful? React with 👍 / 👎.
3 participants
No description provided.