Test eService implementation #97
Conversation
There was a problem hiding this comment.
I’ve left some comments, please review them and address each one.
Also, don’t forget to update the main README file of the eID-Server.
You should add a section explaining how to test the server with the test-eService, and include a link to the corresponding folder so others can easily find the documentation on how to set it up and run it.
Hermann-Core
changed the title
There was a problem hiding this comment.
I reviewed the code again, globally it evrything seems ok but I still see some comments that have not been addressed. Could you carefully check them ? Also I don't see any section in the README of the eID-Server about the test setup as mentioned in my previous comment.
You should add a section explaining how to test the server with the test-eService, and include a link to the corresponding folder so others can easily find the documentation on how to set it up and run it.
| ```toml | ||
| your-project/ | ||
| ├── certs/ | ||
| │ ├── server.crt # HTTPS server certificate | ||
| │ ├── server.key # HTTPS server private key | ||
| │ ├── client.crt # mTLS client certificate | ||
| │ ├── client.key # mTLS client private key | ||
| │ └── server-ca.crt # eID-Server CA certificate (optional) | ||
| ├── .env.local | ||
| └── ... | ||
| ``` |
There was a problem hiding this comment.
I don't know why that is appearing but it is correctly setUp
3 participants
No description provided.