-
Couldn't load subscription status.
- Fork 1
31 design and implement shared reusable search bar component #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nancymuyeh
wants to merge
32
commits into
main
Choose a base branch
from
31-design-and-implement-shared-reusable-search-bar-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
33c23f3
feat(ui): implement reusable SearchBar component
nancymuyeh dadff60
feat(ui): implement reusable SearchBar component
nancymuyeh 02fdf91
feat(ui): implement reusable SearchBar component
nancymuyeh 07f3c4a
feat(ui): implement reusable SearchBar component
nancymuyeh 581d387
Merge branch 'main' into 31-design-and-implement-shared-reusable-sear…
nancymuyeh 62a576d
fix(ui): mark SearchBar component prop as read-only
nancymuyeh 0f3de59
Merge branch '31-design-and-implement-shared-reusable-search-bar-comp…
nancymuyeh d886154
fix(ui): increase test coverage
nancymuyeh b198f93
Merge branch 'main' into 31-design-and-implement-shared-reusable-sear…
nancymuyeh 190f0b3
fix(ui): increase test coverage
nancymuyeh a24a3d9
fix(ui): refactor useSearchBar hook with extracted helper functions f…
nancymuyeh a74f693
fix(ui): refactor useSearchBar hook with extracted helper functions f…
nancymuyeh 390b514
Update packages/ui/src/components/SearchBar/SearchBar.view.tsx
nancymuyeh 7f2e481
fix(ui): refactor useSearchBar component for SonarQube compliance
nancymuyeh 5f5396c
fix(ui): refactor useSearchBar component for SonarQube compliance
nancymuyeh 216d993
fix(ui): refactor SearchBar component for SonarQube compliance
nancymuyeh e04b8bd
fix(ui): refactor SearchBar component for SonarQube compliance
nancymuyeh 3328a72
chore(ui): merge main
nancymuyeh 89b66c6
fix(ui): refactor SearchBar component for SonarQube compliance
nancymuyeh 1161ec1
fix(ui): refactor SearchBar component with more simplifies functionality
nancymuyeh cd8acd7
fix(ui): update searchbar variants and styling
nancymuyeh 1e6e858
fix(ui): remove unused dependencies
nancymuyeh 103e6c8
fix(ui): remove unused dependencies
nancymuyeh 0cd4017
fix(ui): update searchbar componenet to use global styling from style…
nancymuyeh 8ba9f4b
Merge branch 'main' into 31-design-and-implement-shared-reusable-sear…
nancymuyeh e885bf6
fix(ui): fix minor lint issue
nancymuyeh 9d2d22f
fix(ui): merge main
nancymuyeh 632273e
Merge remote-tracking branch 'origin' into 31-design-and-implement-sh…
nancymuyeh eafd972
Merge branch 'main' into 31-design-and-implement-shared-reusable-sear…
nancymuyeh 0fffcc2
Merge branch '31-design-and-implement-shared-reusable-search-bar-comp…
nancymuyeh 9999bf2
fix(ui): fix minor lint issue
nancymuyeh f87027b
fix(ui): fix minor lint issue
nancymuyeh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| # Fineract-apps Copilot Instructions | ||
|
|
||
| This document provides guidance for AI coding agents to effectively contribute to the `fineract-apps` repository. | ||
|
|
||
| ## Project Overview | ||
|
|
||
| This is a monorepo for modern frontend applications built with Vite, React, TypeScript, and Tailwind CSS. The project is structured as a pnpm workspace. | ||
|
|
||
| - `frontend/`: Contains the individual React applications (`account-manager-app`, `branch-manager-app`, `cashier-app`). | ||
| - `packages/`: Contains shared code, including: | ||
| - `ui`: A shared component library. | ||
| - `config`: Shared configurations for tools like TypeScript and Vite. | ||
|
|
||
| ## Key Technologies | ||
|
|
||
| - **Build Tool**: Vite | ||
| - **Framework**: React with TypeScript | ||
| - **Styling**: Tailwind CSS | ||
| - **Package Manager**: pnpm with workspaces | ||
| - **Code Quality**: Biome (for linting and formatting) | ||
| - **Git Hooks**: Husky and commitlint | ||
|
|
||
| ## Development Workflow | ||
|
|
||
| ### Getting Started | ||
|
|
||
| 1. Install dependencies from the root of the project: | ||
| ```bash | ||
| pnpm install | ||
| ``` | ||
|
|
||
| 2. Run a specific application's development server: | ||
| ```bash | ||
| pnpm --filter <app-name> dev | ||
| ``` | ||
| For example, to run `account-manager-app`: | ||
| ```bash | ||
| pnpm --filter account-manager-app dev | ||
| ``` | ||
|
|
||
| ### Building | ||
|
|
||
| To build all applications and packages: | ||
|
|
||
| ```bash | ||
| pnpm build | ||
| ``` | ||
|
|
||
| To build a specific application: | ||
|
|
||
| ```bash | ||
| pnpm --filter <app-name> build | ||
| ``` | ||
|
|
||
| ### Testing | ||
|
|
||
| Tests are written with Jest and React Testing Library. Test files are located alongside the components they test (e.g., `Component.test.tsx`). | ||
|
|
||
| Run all tests: | ||
|
|
||
| ```bash | ||
| pnpm test | ||
| ``` | ||
|
|
||
| ### Code Quality | ||
|
|
||
| - **Linting and Formatting**: This project uses Biome. | ||
| - Check for issues: `pnpm lint` | ||
| - Format code: `pnpm format` | ||
| - **Commit Messages**: Commit messages must follow the [Conventional Commits](https://www.conventionalcommits.org/) specification. This is enforced by a `commit-msg` hook. | ||
|
|
||
| ## Architectural Patterns | ||
|
|
||
| - **Shared UI Components**: Reusable UI components are located in `packages/ui/src/components`. When creating a new component that might be used across multiple applications, it should be added here. | ||
| - **Shared Configuration**: Base configurations for TypeScript (`tsconfig.base.json`) and Vite (`vite.config.base.js`) are in `packages/config`. Application-specific configurations extend these base configs. | ||
| - **Monorepo Structure**: The use of pnpm workspaces allows for easy management of dependencies and inter-package linking. When adding a dependency to a specific app, use the `--filter` flag with `pnpm add`. | ||
|
|
||
| ## Important Files | ||
|
|
||
| - `pnpm-workspace.yaml`: Defines the workspaces in the monorepo. | ||
| - `biome.json`: Configuration for the Biome toolchain. | ||
| - `packages/ui/src/index.ts`: The entry point for the shared UI component library. | ||
| - `frontend/*/vite.config.ts`: Vite configuration for each application, which extends the base configuration. | ||
|
|
||
| ## Component Development Best Practices | ||
|
|
||
| ### Reusable Component Architecture | ||
|
|
||
| When developing shared components in `packages/ui/src/components`, follow these proven patterns: | ||
|
|
||
| #### 1. **File Structure Pattern** | ||
| ``` | ||
| ComponentName/ | ||
| ├── index.tsx # Main component export | ||
| ├── ComponentName.types.ts # TypeScript interfaces | ||
| ├── ComponentName.styles.ts # Tailwind variants with CVA | ||
| ├── ComponentName.view.tsx # Presentational component | ||
| ├── useComponentName.ts # Custom hooks (if needed) | ||
| ├── ComponentName.test.tsx # Comprehensive test suite | ||
| └── ComponentName.stories.tsx # Storybook stories (optional) | ||
| ``` | ||
|
|
||
| #### 2. **TypeScript Best Practices** | ||
| - Use `Readonly<>` wrapper for all component props to enforce immutability | ||
| - Define strict interfaces with proper JSDoc documentation | ||
| - Use union types for variants (e.g., `"default" | "withButton"`) | ||
| - Export all types from the main component file for external use | ||
|
|
||
| #### 3. **Testing Strategy** | ||
| - Aim for **98%+ code coverage** on shared components | ||
| - Test all user interactions (click, keyboard, focus) | ||
| - Test error scenarios and edge cases | ||
| - Use `@testing-library/react` patterns for accessibility testing | ||
| - Include tests for: | ||
| - Rendering with different props | ||
| - User interactions | ||
| - Async behavior | ||
| - Error handling | ||
| - Accessibility features | ||
|
|
||
| #### 4. **Accessibility Standards** | ||
| - Follow WAI-ARIA guidelines strictly | ||
| - Implement proper keyboard navigation | ||
| - Use semantic HTML elements | ||
| - Include ARIA labels and descriptions | ||
| - Test with screen readers | ||
| - Support focus management | ||
| - Use `downshift` for complex interactive components | ||
|
|
||
| #### 5. **Performance Optimization** | ||
| - Use React.memo for expensive components | ||
| - Implement proper debouncing for search/input components | ||
| - Use AbortController for canceling async requests | ||
| - Minimize re-renders with useCallback and useMemo | ||
| - Handle cleanup properly in useEffect | ||
|
|
||
| #### 6. **Styling with Tailwind & CVA** | ||
| - Use `class-variance-authority` (CVA) for component variants | ||
| - Create reusable style variants in separate `.styles.ts` files | ||
| - Use `cn()` utility for conditional class merging | ||
| - Follow consistent spacing and sizing patterns | ||
| - Support responsive design by default | ||
|
|
||
| #### 7. **Code Quality & SonarQube Compliance** | ||
| - Keep **cognitive complexity** under 15 per function | ||
| - Keep **cyclomatic complexity** under 10 per function | ||
| - Extract helper functions/components to reduce complexity | ||
| - Use meaningful variable and function names | ||
| - Add proper JSDoc comments for complex logic | ||
| - Handle all error scenarios gracefully | ||
|
|
||
| #### 8. **Documentation Standards** | ||
| - Create comprehensive markdown documentation in `docs/shared-components/` | ||
| - Include: | ||
| - Component overview and features | ||
| - Complete props table with types and descriptions | ||
| - Multiple usage examples | ||
| - Accessibility notes | ||
| - Common patterns and best practices | ||
| - Use TypeScript examples in documentation | ||
| - Keep examples up-to-date with actual component API | ||
|
|
||
| ### Example: SearchBar Component Implementation | ||
|
|
||
| The SearchBar component serves as a reference implementation showcasing all best practices: | ||
|
|
||
| - **98.01% test coverage** with 30 comprehensive test cases | ||
| - **Full accessibility** with ARIA support and keyboard navigation | ||
| - **Performance optimized** with debouncing and request cancellation | ||
| - **Type safe** with strict TypeScript interfaces | ||
| - **SonarQube compliant** with extracted helper functions for complexity reduction | ||
| - **Comprehensive documentation** with multiple usage examples | ||
| - **Flexible API** supporting both sync and async suggestions | ||
|
|
||
| Key implementation techniques used: | ||
| - Custom hooks for complex logic (`useSearchBar`) | ||
| - Component composition for complexity reduction | ||
| - Proper error handling with AbortController | ||
| - Debounced input with custom hook | ||
| - Accessible dropdown with Downshift | ||
| - CVA for style variants | ||
| - Comprehensive test coverage | ||
|
|
||
| ### Quality Gates & CI/CD | ||
|
|
||
| All shared components must pass: | ||
| - ✅ **Jest tests** with 95%+ coverage | ||
| - ✅ **Biome linting** with no errors | ||
| - ✅ **TypeScript compilation** with strict mode | ||
| - ✅ **SonarQube quality gates** (complexity, coverage, duplicates) | ||
| - ✅ **Accessibility testing** with appropriate ARIA attributes | ||
| - ✅ **Visual regression tests** (when applicable) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.