Skip to content

Conversation

@NkwaTambe
Copy link

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Collaborator

@guymoyo guymoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it should work if you test it with staff id and date.
But this pull request is mixed with another feature other than teller.
myorg should be adorsys?
do we have a kind of eadme for custom extension?

@NkwaTambe
Copy link
Author

Overall I think it should work if you test it with staff id and date. But this pull request is mixed with another feature other than teller. myorg should be adorsys? do we have a kind of eadme for custom extension?

Yes @guymoyo .. I should replace Myorg with adorsys...

Also for the other files , it's because i did a git checkout from the Apache proxy configuration branch instead of checking out from the deveop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants