Pass through API key expiry and metadata #4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| let create_api_key = CreateApiKey { | ||
| expires_at: None, | ||
| metadata: None, | ||
| expires_at: input.expires_at, | ||
| metadata: input.metadata, |
There was a problem hiding this comment.
[P1] Persist metadata in real repository
Forwarding metadata here suggests API clients can store arbitrary metadata, and the new test verifies it against the in‑memory mock. However, the production repository still discards metadata (ApiKeyRepo::create_impl never writes it and mappers::to_api_key hardcodes metadata: None), so real API responses will always return None. The new test therefore gives false confidence and the feature remains non‑functional for the actual DB-backed implementation.
Useful? React with 👍 / 👎.
|
@codex fix the failing pipeline with fmt |
|
Summary
Testing
|
|
@codex fix the failing pipeline |
Summary
Testing
|
1 participant
Summary
expires_atandmetadatawhen creating or patching API keysexpires_atandmetadataTesting
cargo test -p lightbridge-authz-resthttps://chatgpt.com/codex/tasks/task_e_68b169aa3c1483298e61359d666cb85c