Skip to content

Refactor and enhance test coverage #68

Merged
IngridPuppet merged 7 commits into
mainfrom
67-improve-test-coverage-of-most-important-classes
Apr 1, 2026
Merged

Refactor and enhance test coverage #68
IngridPuppet merged 7 commits into
mainfrom
67-improve-test-coverage-of-most-important-classes

Conversation

@mbunwe-victor

@mbunwe-victor mbunwe-victor commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Closes: #67

image image Screenshot from 2026-03-25 11-17-55

@IngridPuppet IngridPuppet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage significantly improved. Could you check the few comments I left upon reviewing?

Comment thread README.md Outdated

@IngridPuppet IngridPuppet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my points were addressed except...

@mbunwe-victor

Copy link
Copy Markdown
Collaborator Author

All my points were addressed except...

Yes, this is what I had
image

@IngridPuppet IngridPuppet reopened this Apr 1, 2026
@IngridPuppet

Copy link
Copy Markdown
Collaborator

Sorry. I didn't mean to close the PR. I confirm getting the same good coverage with JaCoCo. There might be something wrong with my IDEA setup. Please check and merge this other patch PR, so JaCoCo is added to the codebase:

…ost-important-classes--patch

Add JaCoCo plugin for test coverage reporting in pom.xml
@IngridPuppet IngridPuppet merged commit 505f061 into main Apr 1, 2026
1 check passed
@IngridPuppet IngridPuppet deleted the 67-improve-test-coverage-of-most-important-classes branch April 1, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve test coverage of most important classes

2 participants