Refine OID4VP JWS Signature Handling and Repair Unit Test Suite#74
Merged
Conversation
…back to RS256 and improve realm context initialization Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
forkimenjeckayang
requested changes
May 15, 2026
forkimenjeckayang
left a comment
forkimenjeckayang
left a comment
Collaborator
There was a problem hiding this comment.
few comments @Awambeng
Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
Collaborator
Author
|
@forkimenjeckayang I’ve addressed the comments. Please take another look when you get the chance. |
mbunwe-victor
requested changes
May 18, 2026
mbunwe-victor
left a comment
mbunwe-victor
left a comment
Collaborator
There was a problem hiding this comment.
Hello @Awambeng, could you check my comments?
Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
forkimenjeckayang
approved these changes
May 18, 2026
forkimenjeckayang
left a comment
forkimenjeckayang
left a comment
Collaborator
There was a problem hiding this comment.
My concerns have been addressed. LGTM
mbunwe-victor
approved these changes
May 18, 2026
mbunwe-victor
left a comment
mbunwe-victor
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for considering my comments, @Awambeng. All comments resolved, and it LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin was throwing
Invalid JWS signatureerrors, and the test suite had several regressions. Specifically:SignatureProviderstubs, causing failures during JWT generation.Solution
ES256→RS256) inCryptoIdentityService.MockKeycloakTestto provide a complete mock environment for JWS signing.KeyFactoryexceptions.Related to ADORSYS-GIS/keycloak-oid4vp-plugin#31