Docs: Fill README CI/CD gap, note LLM_API_KEY, and fix doc rot - #354
Conversation
📝 WalkthroughWalkthroughDocumentation is updated for GenAI environment requirements, CI/CD workflows, system architecture and deployment, UML diagrams, Spring microservice routing, and generated GenAI client models. ChangesDocumentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/System_Overview.md`:
- Line 100: Update the deployment-trigger wording in the system overview
paragraph to state that GitHub Actions deploys on pushes to main, replacing the
current merge-only wording while leaving the rest of the CI description
unchanged.
In `@README.md`:
- Around line 48-52: Update the README’s GenAI feature description to
distinguish semantic search from AI enrichment: without LLM_API_KEY, document
summaries, tag extraction, entity extraction, and Q&A return errors, while
semantic search falls back to keyword results as documented in
services/spring/README.md. Keep the environment setup and configuration guidance
unchanged.
In `@services/spring/README.md`:
- Around line 27-28: Update the README processing documentation to state that
only summary, entities, and tags have reprocess endpoints; replace the broader
“Every step” wording without implying indexing can be reprocessed. Keep the
existing route list and tag behavior description unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6060b66d-3243-43e8-8d71-bcbf872b59bd
📒 Files selected for processing (3)
README.mddocs/System_Overview.mdservices/spring/README.md
What does this PR do?
A few documentation gaps and some doc rot that reviewers kept tripping over. All docs, no code.
LLM_API_KEY. A colddocker compose upboots a working app, but every GenAI feature (summary, tags, entity extraction, semantic search, Q&A) errors until an LLM key is set. That was only explained in.env.exampleand the genai README, not where a tutor actually starts. Added a short note to the quickstart and flagged the key as the one env var without a usable default.System_Overview.mdand the infra READMEs (the root had badges plus links). Added a short section describing what CI runs on a PR and what CD does on a push to main, with links to the workflows.services/spring/README.mdnow spells out thatcom.alexandria.genai.client.*(theAiApiGenAiClientwraps) is produced by the GradleopenApiGeneratetask fromapi/openapi.yaml, not hand-written, and must not be edited by hand. Note the mechanism is the Gradle build (wired tocompileJava); the pre-commit hooks keep the spec it generates from in sync.System_Overview.md. The realm path wasoidc/realm.json(actuallyinfra/oidc/realm.json), and it claimed "one Dockerfile per component" which isn't true: the three Spring services share one parameterised Dockerfile and the DB/infra run from stock images. Reworded to match reality.Type of change
Definition of Done
api/openapi.yamlis updated and lint passesdocker compose up)Notes for the reviewer
Summary by CodeRabbit
.envconfiguration.