CI: Pin Azure deploy to commit SHA, prune images, make Prometheus private - #356
Conversation
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ladu-tu
left a comment
There was a problem hiding this comment.
Thanks for all the cleanup work!
What does this PR do?
Brings the Azure VM deploy up to the same rigor the Kubernetes path already has, and closes an open Prometheus on the public deployment.
Pin deployed images to the commit SHA + prune old ones. The k8s deploy passes
image.tag=<sha>to Helm, but the VM just diddocker compose pullagainstghcr.io/...:latest, so it ran "whatever latest was at pull time": not traceable to a commit, racy when two merges queue, and impossible to roll back precisely.docker-compose.ymlnow uses:${IMAGE_TAG:-latest}for the five app images, so it still defaults to:latestfor local/manual use.IMAGE_TAG(from the newimage_tagvar) intodocker compose pullandup, defaulting tolatestwhen unset.Deploy to Azure VMjob passes the built short SHA (needs.build-image.outputs.image-tag, the same value k8s already uses) asimage_tag.docker image prune -af --filter until=168h) after each deploy, so old SHA-tagged layers stop piling up until the disk fills.Keep Prometheus off the public router. On the public (Let's Encrypt) deployment,
/prometheuswas reachable unauthenticated: the TLS overlay only added TLS, no auth. In k8s Prometheus is private (port-forward only) and only Grafana is exposed (behind Keycloak). The overlay now disables the Prometheus Traefik router and publishes it on the VM's loopback (127.0.0.1:9090), so it's reachable via an SSH tunnel (ssh -L 9090:localhost:9090 <vm>), mirroringkubectl port-forward. Local dev is unchanged: it doesn't use the overlay, sohttp://localhost/prometheus/still works.Type of change
Definition of Done
api/openapi.yamlis updated and lint passesdocker compose up)Notes for the reviewer