Skip to content

fix grafana dashboard for kubernetes - #83

Merged
maliklesch merged 1 commit into
mainfrom
fix/grafana
Jul 3, 2026
Merged

maliklesch merged 1 commit into
mainfrom
fix/grafana

Conversation

@maliklesch

@maliklesch maliklesch commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added configurable CPU and memory requests/limits for Grafana and Prometheus in the monitoring stack.
    • Deployment templates now apply these resource settings during installation or upgrade, helping improve cluster scheduling and resource control.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aabfd6e3-ac79-4219-a40f-4cdaebed852b

📥 Commits

Reviewing files that changed from the base of the PR and between 142b013 and 24fc2aa.

📒 Files selected for processing (3)
  • helm/bytebite/templates/grafana-deployment.yaml
  • helm/bytebite/templates/prometheus-deployment.yaml
  • helm/bytebite/values.yaml

📝 Walkthrough

Walkthrough

This PR adds Kubernetes resource requests/limits configuration for the Prometheus and Grafana deployments. New resources values are defined in values.yaml, and both deployment templates now render these values into their container specs.

Changes

Monitoring resource configuration

Layer / File(s) Summary
Resource values for Prometheus and Grafana
helm/bytebite/values.yaml
Adds monitoring.prometheus.resources and monitoring.grafana.resources with CPU/memory limits and requests.
Deployment template wiring
helm/bytebite/templates/grafana-deployment.yaml, helm/bytebite/templates/prometheus-deployment.yaml
Adds a resources block to each container, rendered via toYaml and nindent from the corresponding values.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None identified.

Suggested labels: helm, monitoring, configuration

Suggested reviewers: None identified.

🐰 Poem

A rabbit hopped through YAML fields so neat,
Gave Grafana and Prometheus limits to eat.
CPU and memory, requests and caps,
No more resources left to chance or gaps.
Hop, hop, hooray — the cluster's in shape! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is broadly aligned with the PR because it concerns Grafana on Kubernetes, though it doesn't mention the new Helm resource settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/grafana

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timn21 timn21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@maliklesch
maliklesch merged commit a04c14f into main Jul 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants