Enable deployments to Azure instance - #46
Merged
alexander-wudy merged 8 commits intoJun 19, 2026
Merged
Conversation
alexander-wudy
force-pushed
the
feature/Setup-Dev-Instance-Deploy-to-Azure-#34
branch
from
June 10, 2026 23:08
36f0c6f to
7484d19
Compare
w-richter
reviewed
Jun 18, 2026
| with: | ||
| key: ${{ secrets.AZURE_VM_SSH_KEY }} | ||
| if_key_exists: replace | ||
| known_hosts: "placeholder" |
Collaborator
There was a problem hiding this comment.
did you accidentally leave a placeholder?
| ansible-playbook playbook.yml \ | ||
| -i "${{ env.AZURE_VM_IP }}," \ | ||
| --user devops-admin \ | ||
| --extra-vars "github_token='${{ secrets.AZURE_PULL_PAT }}' ansible_ssh_common_args='-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null'" |
Collaborator
There was a problem hiding this comment.
ssh known hosts is being completely ignored anyways because of
ansible_ssh_common_args='-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null'
if intentional ignore this and other inline comment
|
|
||
| if [ -n "$POSTGRES_MULTIPLE_DATABASES" ]; then | ||
| echo "Multiple database creation requested: $POSTGRES_MULTIPLE_DATABASES" | ||
| for db in $(echo $POSTGRES_MULTIPLE_DATABASES | tr ',' ' '); do |
Collaborator
There was a problem hiding this comment.
would fail if database name ever had spaces or special chars, unlikely but simple fix
IFS=',' read -ra DBS <<< "$POSTGRES_MULTIPLE_DATABASES"
for db in "${DBS[@]}"; do
create_database "$db"
done| @@ -0,0 +1,73 @@ | |||
| name: deploy-azure.yml | |||
Collaborator
There was a problem hiding this comment.
convention is human readable:
Suggested change
| name: deploy-azure.yml | |
| name: Deploy to Azure |
Collaborator
|
lgtm now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automatic deployments might not immediately work, as I will have to probably tinker with the GitHub Secrets for a short bit. But otherwise, this should be the implementation for Terraform and Ansible