fix speaking error - #142
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR adds a catalog-backed software-engineering speaking track, localizes learning responses and exercise formats, requires target language for speaking submissions, propagates it through evaluation, and adds frontend language-switch loading behavior. ChangesSpeaking language flow
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/learning-service/src/main/resources/default-learning-plans.json (1)
1445-1445: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueStandardize the German register in this track. Several prompts mix informal
du/deineand formalSie/Ihrephrasing in the same entry, e.g.Nimm deine Antwort auf: Warum interessieren Sie sich .... Pick one tone and apply it consistently across the new German catalog items.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/learning-service/src/main/resources/default-learning-plans.json` at line 1445, Review the new German catalog entries in default-learning-plans.json and standardize each entry to a single register, consistently using either informal du/deine or formal Sie/Ihre phrasing. Update mixed prompts such as those combining “Nimm deine” with “Sie” so all instructions and pronouns within each track use the selected tone.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/learning-service/src/main/resources/default-learning-plans.json`:
- Line 1331: Update the German question prompts in the listed learning-plan
entries to use consistent informal address: replace formal Sie/Ihre wording with
du/dein forms and use informal imperatives such as “Erzähle”. Apply the same
wording consistently to the entries at the referenced question locations while
preserving their existing meaning and answer-duration requirements.
---
Nitpick comments:
In `@backend/learning-service/src/main/resources/default-learning-plans.json`:
- Line 1445: Review the new German catalog entries in
default-learning-plans.json and standardize each entry to a single register,
consistently using either informal du/deine or formal Sie/Ihre phrasing. Update
mixed prompts such as those combining “Nimm deine” with “Sie” so all
instructions and pronouns within each track use the selected tone.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d186979b-c729-4119-a51a-22ef970b2e63
📒 Files selected for processing (19)
api/openapi.yamlapi/services/progress-feedback-service.yamlbackend/learning-service/src/main/java/de/tum/aet/devops26/learning_service/service/LearningPlanSeeder.javabackend/learning-service/src/main/java/de/tum/aet/devops26/learning_service/service/LearningPlanService.javabackend/learning-service/src/main/java/de/tum/aet/devops26/learning_service/service/LessonService.javabackend/learning-service/src/main/java/de/tum/aet/devops26/learning_service/service/catalog/DefaultExerciseTemplate.javabackend/learning-service/src/main/resources/default-learning-plans.jsonbackend/learning-service/src/test/java/de/tum/aet/devops26/learning_service/service/LearningPlanSeederTests.javabackend/learning-service/src/test/java/de/tum/aet/devops26/learning_service/service/LearningPlanServiceTests.javabackend/learning-service/src/test/java/de/tum/aet/devops26/learning_service/service/LessonServiceTests.javabackend/learning-service/src/test/java/de/tum/aet/devops26/learning_service/service/catalog/DefaultLearningPlanCatalogTests.javabackend/progress-feedback-service/src/main/java/de/tum/aet/devops26/progress_feedback_service/api/impl/ProgressFeedbackServiceController.javabackend/progress-feedback-service/src/main/java/de/tum/aet/devops26/progress_feedback_service/service/UserAnswerService.javabackend/progress-feedback-service/src/test/java/de/tum/aet/devops26/progress_feedback_service/service/UserAnswerServiceTests.javafrontend/src/App.jsxfrontend/src/api/client.test.jsfrontend/src/components/LanguageSwitchOverlay.jsxfrontend/src/pages/LanguagePage.jsxfrontend/src/styles.css
| "topic": "Präsentiere deinen Hintergrund, deine Motivation und deine Stärken als Kandidatin oder Kandidat im Software Engineering.", | ||
| "exercises": [ | ||
| { | ||
| "question": "Nimm eine 45-sekündige Antwort auf: Erzählen Sie mir etwas über sich als Kandidatin oder Kandidat im Software Engineering.", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use one form of address throughout the German prompts.
These strings mix informal wrappers such as “Nimm deine Antwort auf” with formal Sie/Ihre questions, while their expected answers use du. Prefer consistent informal wording such as “Erzähle”, “interessierst du dich”, and “deiner”.
Also applies to: 1342-1342, 1353-1353, 1370-1370, 1381-1381, 1392-1392, 1431-1431
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/learning-service/src/main/resources/default-learning-plans.json` at
line 1331, Update the German question prompts in the listed learning-plan
entries to use consistent informal address: replace formal Sie/Ihre wording with
du/dein forms and use informal imperatives such as “Erzähle”. Apply the same
wording consistently to the entries at the referenced question locations while
preserving their existing meaning and answer-duration requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_languageSpeaking lessons
Each lesson contains three
speaking_promptexercises with localized prompts, expected answers, and keyword hints.API changes
target_languagefor speaking submissionsCompatibility
Existing
Everyday Speaking Practiceplans are not modified. Existing users receive the new speaking track once without duplicate creation.Testing
Summary by CodeRabbit
New Features
Bug Fixes